Open tienifr opened 1 week ago
@ShridharGoel will review this PR as C+ role based on comment https://github.com/Expensify/App/issues/40699#issuecomment-2070536090
@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
@ShridharGoel Can you always reproduce this bug in Android?
@ShridharGoel can you please complete the checklist?
Hello, I'm on vacation for 2 days and will test this on Friday.
@tienifr It's difficult to replicate since it's a race condition. Can you try changing the workspace avatar multiple times?
:test_tube::test_tube: Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! :test_tube::test_tube: | Android :robot: | iOS :apple: |
---|---|---|
❌ FAILED ❌ | https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/40872/index.html | |
The QR code can't be generated, because the android build failed | ||
Desktop :computer: | Web :spider_web: | |
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/40872/NewExpensify.dmg | https://40872.pr-testing.expensify.com | |
:eyes: View the workflow run that generated this build :eyes:
Can you try changing the workspace avatar multiple times
I tried but still could not reproduce. Let me try again.
@ShridharGoel Can you help review the PR once you have a chance? Thanks
Will be testing this today, I was OOO.
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and not onIconClick
).myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components using Avatar
have been tested & I retested again)/** comment above it */
this
properly so there are no scoping issues (i.e. for onClick={this.submit}
the method this.submit
should be bound to this
in the constructor)this
are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this);
if this.submit
is never passed to a component event handler like onClick
)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG
)Avatar
is modified, I verified that Avatar
is working as expected in all cases)Design
label and/or tagged @Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test
steps.@tienifr Can you complete the author checklist and add the testing steps? We can also do some sanity testing at places where the library is used.
I've tested the workspace avatar uploading flow.
@ShridharGoel I updated the test steps
However, I faced an issue when running android on my device so I could not test.
@mountiny Can you help create an ad-hoc build? Thanks
Now I can run Android on my device and it works well
I'll test again in sometime and then approve.
On Fri, May 3, 2024, 10:12 AM Tienifr @.***> wrote:
Now I can run Android on my device and it works well
— Reply to this email directly, view it on GitHub https://github.com/Expensify/App/pull/40872#issuecomment-2092112283, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIPLJHFU4VOE576S777GC2LZAMISVAVCNFSM6AAAAABGWYHPPWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJSGEYTEMRYGM . You are receiving this because you were mentioned.Message ID: @.***>
Details
Fixed Issues
$ https://github.com/Expensify/App/issues/40699 PROPOSAL: https://github.com/Expensify/App/issues/40699#issuecomment-2069610317
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
https://github.com/Expensify/App/assets/113963320/cef24359-cd7e-4ffc-a947-dcb53e137662Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop