search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
2.97k stars 2.48k forks source link

Track expense - In track expense, edit amount shows dollar briefly #40873

Open izarutskaya opened 1 week ago

izarutskaya commented 1 week ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.65-0 Reproducible in staging?: Y Reproducible in production?: N Found when validating PR : https://github.com/Expensify/App/pull/39956 Logs: https://stackoverflow.com/c/expensify/questions/4856 Issue reported by: Applause-Internal team

Action Performed:

  1. Go to https://staging.new.expensify.com/home
  2. Tap on a chat --- tap the FAB > track expense
  3. Enter an amount > change currency to RP> tap next
  4. Tap track expense (add a merchant when required)
  5. Tap on newly created expense to open epense details
  6. Tap amount to edit the currency
  7. Choose RP > Save
  8. Tap on amount to edit current
  9. Choose RP > Save
  10. Notice the $ shows for a brief moment after Saving expense and while the changes loading

Expected Result:

In track expense when clicking indian Rupee (RP), edit amount should not show any other currency

Actual Result:

In track expense while the amount in Indian Rupee (RP), edit amount shows dollar briefly.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

https://github.com/Expensify/App/assets/115492554/3e90961c-8e37-4cc6-b53e-5597cfcb874c

https://github.com/Expensify/App/assets/51066321/b31ffbbe-8582-470e-9f32-adbd0f525bc6

View all open jobs on GitHub

melvin-bot[bot] commented 1 week ago

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] commented 1 week ago

Triggered auto assignment to @hayata-suenaga (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

github-actions[bot] commented 1 week ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
izarutskaya commented 1 week ago

@Christinadobrzyn I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

izarutskaya commented 1 week ago

We think this issue might be related to the #vip-vsb.

mountiny commented 1 week ago

Seems like a second regression from https://github.com/Expensify/App/pull/39956 @shubham1206agra @thienlnam @allroundexperts

Its minor as well, can you follow up with a quick fix

mountiny commented 1 week ago

demoting this as its minor but @shubham1206agra @allroundexperts assinging you as this is most likely coming from your PR

melvin-bot[bot] commented 6 days ago

@allroundexperts, @thienlnam, @Christinadobrzyn, @shubham1206agra Huh... This is 4 days overdue. Who can take care of this?

Christinadobrzyn commented 5 days ago

Just checking, are we creating a new PR for this issue? @allroundexperts @shubham1206agra?

allroundexperts commented 5 days ago

I think @shubham1206agra were unable to reproduce this. Is this correct @shubham1206agra?

shubham1206agra commented 5 days ago

I was unable to repro this

Christinadobrzyn commented 5 days ago

I can't reproduce this either. I'll ask QA to test - https://expensify.slack.com/archives/C9YU7BX5M/p1714468168251599

kavimuru commented 5 days ago

Bug is still reproduced.

https://github.com/Expensify/App/assets/43996225/bdb940c5-553f-4106-9862-fea6f9447848

Christinadobrzyn commented 3 days ago

I'm still not able to reproduce this... @shubham1206agra or @allroundexperts can you test again and let me know if you get this?

Christinadobrzyn commented 2 days ago

Okay, I was able to reproduce this again when testing on iOS app - I uploaded the video to the OP and updated the steps.

Since this only seems to be affecting RP currency, I'm inclined to close this as a not critical, edge case, not part of our ROI. We can reevaluate it at a later time.

@thienlnam @allroundexperts what are your thoughts?