[HOLD for payment 2024-05-03] Unable to load categories in the workspace settings

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.

https://new.expensify.com

MIT License

2.97k stars 2.48k forks source link

[HOLD for payment 2024-05-03] Unable to load categories in the workspace settings #40875

Open mountiny opened 1 week ago

mountiny commented 1 week ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: v1.4.65-2 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @trjExpensify Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1713951624767449

Action Performed:

Break down in numbered steps

Have a collect policy on the beta
This policy should have categories set up
Sign into this account
Go to the workspace settings
Go to Categories page

Expected Result:

Describe what you think should've happened

the categories list should load without issues

Actual Result:

Describe what actually happened

Infinite spinner is showing

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

melvin-bot[bot] commented 1 week ago

Current assignee @mountiny is eligible for the DeployBlockerCash assigner, not assigning anyone new.

melvin-bot[bot] commented 1 week ago

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

github-actions[bot] commented 1 week ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

mountiny commented 1 week ago

reverting https://github.com/Expensify/App/pull/40496/files fixes the issue

s77rt commented 1 week ago

This is a known problem https://github.com/Expensify/App/pull/39132#discussion_r1571085835 It seems that https://github.com/Expensify/App/pull/40375 didn't fix it

s77rt commented 1 week ago

cc @hayata-suenaga

hayata-suenaga commented 1 week ago

PR was merged. requesting cherry pick -> https://expensify.slack.com/archives/C07J32337/p1713970530252449

melvin-bot[bot] commented 1 week ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 1 week ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.65-5 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/40893

If no regressions arise, payment will be issued on 2024-05-02. :confetti_ball:

melvin-bot[bot] commented 1 week ago

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@mountiny] The PR that introduced the bug has been identified. Link to the PR:
[ ] [@mountiny] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [@mountiny] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [@mountiny] Determine if we should create a regression test for this bug.
[ ] [@mountiny] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[ ] [@sonialiap] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

melvin-bot[bot] commented 1 week ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.66-5 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/40893

If no regressions arise, payment will be issued on 2024-05-03. :confetti_ball:

melvin-bot[bot] commented 1 week ago

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@mountiny] The PR that introduced the bug has been identified. Link to the PR:
[ ] [@mountiny] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [@mountiny] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [@mountiny] Determine if we should create a regression test for this bug.
[ ] [@mountiny] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[ ] [@sonialiap] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

melvin-bot[bot] commented 3 days ago

Current assignee @sonialiap is eligible for the Bug assigner, not assigning anyone new.

melvin-bot[bot] commented 3 days ago

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

sonialiap commented 3 days ago

@abekkala I'm OOO 2024-05-03 to 2024-05-06 so adding a BZ buddy to issue payment if I'm out when it becomes due

abekkala commented 3 days ago

@sonialiap - what is the payment summary?

@mountiny it looks like you provided the fix and @s77rt did the PR review, correct? Was that a $250 PR review or some other amount?

s77rt commented 3 days ago

No payment is needed here since it was a regression

melvin-bot[bot] commented 2 days ago

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.