Open kbecciv opened 1 week ago
Triggered auto assignment to @flodnv (DeployBlockerCash
), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.
:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
We think that this bug might be related to #wave-collect - Release 1
Taking over
I think we discussed before if we should even allow the deeplink once user completed the flow @trjExpensify
Nevertheless this is not a blocker as its minor ui bug
I think we discussed before if we should even allow the deeplink once user completed the flow @trjExpensify
I don't recall that, but it kinda' makes sense. If they've completed onboarding and in-product natively we don't show it again -- then getting there via deeplink shouldn't work either.
Job added to Upwork: https://www.upwork.com/jobs/~01a5d3f767fe2611e7
Updated the instructions
Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External
)
Do not allow user repeat the onboarding steps when already completed the onboarding steps
New feature
Backend sends {nvp_onboarding: {hasCompletedGuidedSetupFlow: true}
and using this value, Two solutions.
AuthScreens.tsx
, thus user will remain on the current report if he/she clicks the onboarding link, or will go to the last report if he/she comes from outside via direct linkConcierge
page, thus user will be redirected to his/her Concierge
page if he/she clicks the link.n/a
Checking. Will update in a while.
Expected result from the post is
When the user already completed the guided setup flow, we should make sure we re-navigate them to the main page after they attempt to deeplink to the flow
So, option 2 of the solution suggested in the proposal here by @skyweb331 looks good to me.
🎀 👀 🎀 C+ Reviewed
Triggered auto assignment to @youssef-lr, see https://stackoverflow.com/c/expensify/questions/7972 for more details.
I am testing the code on Android and IOS.
@youssef-lr, @mountiny, @c3024 Whoops! This issue is 2 days overdue. Let's get this updated quick!
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.65-0 Reproducible in staging?: y Reproducible in production?: n Issue reported by: Applause - Internal Team Issue found when executing PR: https://github.com/Expensify/App/pull/40667
Action Performed:
Expected Result:
When the user already completed the guided setup flow, we should make sure we re-navigate them to the main page after they attempt to deeplink to the flow
Actual Result:
Users can go through the onboarding flow as many times as they want
Workaround:
n/a
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/93399543/5538576a-840c-4367-8c8d-ee14a5f55f0b
View all open jobs on GitHub
Upwork Automation - Do Not Edit