Closed ren-jones closed 6 days ago
@rushatgabhane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
π Cherry-picked to staging by https://github.com/francoisl in version: 1.4.67-7 π
platform | result |
---|---|
π€ android π€ | failure β |
π₯ desktop π₯ | success β |
π iOS π | success β |
πΈ web πΈ | success β |
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.
π Deployed to staging by https://github.com/amyevans in version: 1.4.68-0 π
platform | result |
---|---|
π€ android π€ | success β |
π₯ desktop π₯ | success β |
π iOS π | failure β |
πΈ web πΈ | success β |
π Cherry-picked to staging by https://github.com/francoisl in version: 1.4.67-7 π
platform | result |
---|---|
π€ android π€ | failure β |
π₯ desktop π₯ | success β |
π iOS π | success β |
πΈ web πΈ | success β |
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.
π Deployed to production by https://github.com/francoisl in version: 1.4.68-3 π
platform | result |
---|---|
π€ android π€ | success β |
π₯ desktop π₯ | success β |
π iOS π | success β |
πΈ web πΈ | success β |
New article
Details
Fixed Issues
$https://github.com/Expensify/App/issues/36581 $https://github.com/Expensify/App/issues/40423 $https://github.com/Expensify/App/issues/40810
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videosundefined