search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
2.97k stars 2.48k forks source link

[$250] Track expense - Distance is not editable after expense tracking is created #40879

Closed kbecciv closed 1 day ago

kbecciv commented 1 week ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.65-0 Reproducible in staging?: y Reproducible in production?: y Issue found when executing PR: https://github.com/Expensify/App/pull/39956 Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to Self DM.
  3. Track a distance expense.
  4. Go to expense thread.

Expected Result:

Distance should be editable.

Actual Result:

Distance is not editable.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/93399543/aa26212c-bf34-424c-ba7c-3dc196169967

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01aa26b2aab67f7bd8
  • Upwork Job ID: 1784826184446623744
  • Last Price Increase: 2024-04-29
melvin-bot[bot] commented 1 week ago

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

kbecciv commented 1 week ago

We think that this bug might be related to #vip-vsb

kbecciv commented 1 week ago

@kadiealexander FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

GandalfGwaihir commented 1 week ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

Cannot edit distance on MoneyRequestView if the report is a Track Expense type.

What is the root cause of that problem?

We have disabled the ability to edit distances in Track Expens by using !isTrackExpense: https://github.com/Expensify/App/blob/9a727de1e67013a8baf2dff018063af03d963ada/src/components/ReportActionItem/MoneyRequestView.tsx#L154-L155

We also have a note above to remove the extra condition.

What changes do you think we should make in order to solve the problem?

We need to remove the extra condition && !isTrackExpense. This will make the request editable on Track Expense as well

Screenshot 2024-04-25 at 3 21 24 AM

What alternative solutions did you explore? (Optional)

N/A

melvin-bot[bot] commented 6 days ago

Job added to Upwork: https://www.upwork.com/jobs/~01aa26b2aab67f7bd8

melvin-bot[bot] commented 6 days ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

Santhosh-Sellavel commented 6 days ago

@kadiealexander Please reassign a new C+ Here. Unassigning due to low availability.

Santhosh-Sellavel commented 6 days ago

@allroundexperts Will take over this as C+!

kadiealexander commented 3 days ago

@allroundexperts could you please review the existing proposals? Thanks!

neil-marcellini commented 1 day ago

This is intentional and will be fixed by this PR, and handled by the related issue [App] [HOLD Web-E 41549] Allow editing distance for tracked expenses