Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.51k stars 2.86k forks source link

[$250] Web - Unable to open public room when user is signed out #40917

Closed lanitochka17 closed 4 months ago

lanitochka17 commented 6 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.65-0 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4506639&group_by=cases:section_id&group_order=asc&group_id=229066 Issue reported by: Applause - Internal Team

Action Performed:

  1. Log out of New Expensify
  2. Navigate to this link as anon user- https://staging.new.expensify.com/r/2652281908731856

Expected Result:

Public room page should open

Actual Result:

Unable to open public room when user is signed out. User can see infinite new expensify logo screen

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/fbc73da1-d3aa-4610-9885-c7310cd017b6

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01af683507cc110cb3
  • Upwork Job ID: 1783171334978912256
  • Last Price Increase: 2024-04-24
melvin-bot[bot] commented 6 months ago

Triggered auto assignment to @stitesExpensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

github-actions[bot] commented 6 months ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
lanitochka17 commented 6 months ago

@stitesExpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

melvin-bot[bot] commented 6 months ago

Job added to Upwork: https://www.upwork.com/jobs/~01af683507cc110cb3

melvin-bot[bot] commented 6 months ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-djouah (External)

mountiny commented 6 months ago

I cannot reproduce, it seems like it might be some backend issue rather than app issue https://github.com/Expensify/App/assets/36083550/6fda6472-6666-4367-a6ce-0b762367e0ea

sword1202 commented 6 months ago

It's not issue only from Mac Chrome/Safari. It happened on Android Phone (Chrome) and iPhone (Safari). screenshot-Google Pixel 8-14 0 screenshot-iPhone 15-17 4

ZhenjaHorbach commented 6 months ago

Actually Looks like BE issue Because when we made openReport request Then we need to wait one minute to get response

proverbed commented 6 months ago

Yes, seems like you just need to wait very long.

mountiny commented 6 months ago

Yep it seems like this is a backend issue where the OpenReport command takes a long time

melvin-bot[bot] commented 6 months ago

Current assignee @rayane-djouah is eligible for the Internal assigner, not assigning anyone new.

mountiny commented 6 months ago

It seems like its related to this discussion

melvin-bot[bot] commented 6 months ago

@stitesExpensify Eep! 4 days overdue now. Issues have feelings too...

stitesExpensify commented 6 months ago

Like Vit said it seems like this is due to general slowness with queries. Going to make this a weekly while that is worked on

stitesExpensify commented 5 months ago

I'm about to be OOO for a while so I'm going to unassign. If this is still not resolved we can add the bug label which will assign the proper people!

melvin-bot[bot] commented 5 months ago

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

melvin-bot[bot] commented 4 months ago

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

mallenexpensify commented 4 months ago

Added Bug to assign a BZ since no one was assigned here. Post in #fast-apis last week about this here.

JmillsExpensify commented 4 months ago

Not sure if we I went ahead and added this to vip-vsb since this issue was created in that initiative. We can re-file when/if fast-apis has a GH project.

melvin-bot[bot] commented 4 months ago

@JmillsExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

JmillsExpensify commented 4 months ago

Public rooms aren't a priority. Closing.

mallenexpensify commented 4 months ago

fwiw, I was able to open the link in the OP without being signed in, on production and staging, Chrome

image
mallenexpensify commented 4 months ago

fwiw, I was able to open the link in the OP without being signed in, on production and staging, Chrome

image