search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.56k stars 2.9k forks source link

[HOLD for payment 2024-06-13] [$250] Split bill / Group chat - When selecting the user search input should clear query and search input should be focused #41049

Closed m-natarajan closed 5 months ago

m-natarajan commented 6 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.66-0 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @shawnborton Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1714064614847909

Action Performed:

  1. Click Fab > Split Expenses
  2. Enter amount and click next
  3. Search for any user and select the user
  4. Clear the search field and search for another user
  5. Notice you don't see the users you've already selected
  6. Select a user
  7. Clear the search field and search for another user
  8. Notice you don't see the users you've already selected
  9. Select a user
  10. Notice you only see the list of users in the group once there is no name in the search field

Expected Result:

Search term clears and search input is focussed - details here- https://github.com/Expensify/App/issues/41049#issuecomment-2088154813

Actual Result:

The search input doesn't clear, so even after you select someone, you have no context in terms of how many other people were selected or who else is available to be selected

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/51066321/b07f6d8b-d763-48b0-8fe1-0660a70b2ab9

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~012a1b93a6a141243d
  • Upwork Job ID: 1783743468031696896
  • Last Price Increase: 2024-04-26
  • Automatic offers:
    • alitoshmatov | Reviewer | 0
    • nkdengineer | Contributor | 0
Issue OwnerCurrent Issue Owner: @alexpensify
nkdengineer commented 5 months ago

@Christinadobrzyn I checked on the latest main and the issue is fixed. Waiting the PR for deploying to staging. Correct me if I missed st.

cc @alitoshmatov.

melvin-bot[bot] commented 5 months ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 5 months ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.79-11 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-06-13. :confetti_ball:

For reference, here are some details about the assignees on this issue:

melvin-bot[bot] commented 5 months ago

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

Christinadobrzyn commented 5 months ago

Payouts due:

Upwork job is here.

Christinadobrzyn commented 5 months ago

@alitoshmatov do we need a regression test?

Christinadobrzyn commented 5 months ago

Just a heads up - I'm going to be ooo until June 24th so going to assign a teammate to pay this out and submit the regression test (if needed)

melvin-bot[bot] commented 5 months ago

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Christinadobrzyn commented 5 months ago

@alexpensify would you mind paying out based on this payment summary and submitting a regression test if we need one? TY!

cc @alitoshmatov

alitoshmatov commented 5 months ago

Regression test steps

  1. Go to FAB > Start chat
  2. Enter a user to search
  3. Click on Add to group button
  4. Verify that the search input is cleared
  5. Go to FAB > Split expense
  6. Enter a valid amount and go to the next step
  7. Search for a user
  8. Select the user and verify that the search input is cleared
alexpensify commented 5 months ago

Everyone here https://github.com/Expensify/App/issues/41049#issuecomment-2162477972 has been paid via Upwork. I'll work on the test GH tomorrow.

MonilBhavsar commented 5 months ago

Latest update ^

alexpensify commented 5 months ago

There were other higher-priority GHs; I'll get to the test soon.

alexpensify commented 5 months ago

Closing - I created the regression test request.