Closed war-in closed 3 days ago
While working on this and recording videos I've encountered a bug (it is present on the main
branch too)
The Password-protected PDF is not supported
warning is not displayed on native apps (iOS and android).
https://github.com/Expensify/App/assets/61014013/d69471fb-e812-4ce7-9ab2-811e9a12d1cd
@s77rt Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
@s77rt I've added changes but it seems that MoneyRequestConfirmationList
changed a lot from yesterday so I'm currently working on resolving the conflict 😓
@war-in Can you please tag me once this is ready for another review
Yup, will re-request review and tag you!
@s77rt It should be ready for review now :)
It turned out that there was another PR doing the same thing :/ I'll merge it and leave only necessary changes
Done, it is ready for review now :)
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and not onIconClick
).myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components using Avatar
have been tested & I retested again)/** comment above it */
this
properly so there are no scoping issues (i.e. for onClick={this.submit}
the method this.submit
should be bound to this
in the constructor)this
are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this);
if this.submit
is never passed to a component event handler like onClick
)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG
)Avatar
is modified, I verified that Avatar
is working as expected in all cases)Design
label and/or tagged @Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test
steps.Can you please fix this styling bug, comparing to staging the user email is right next to the amount
@s77rt Fixed :)
:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.
Details
Fixed Issues
$ https://github.com/Expensify/App/issues/25125 PROPOSAL:
Tests
Show more
andSubmit
buttons (depending on the room size).Password-protected PDF is not supported
)Offline tests
QA Steps
Show more
andSubmit
buttons (depending on the room size).Password-protected PDF is not supported
)PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
https://github.com/Expensify/App/assets/61014013/1109851c-ae1d-4e90-b08d-d4c8b97d2da2Android: mWeb Chrome
https://github.com/Expensify/App/assets/61014013/e986de25-9b24-40f9-abf0-76ad1641ee02iOS: Native
https://github.com/Expensify/App/assets/61014013/3a9c4fa6-04ea-4c88-8567-14142839bf4aiOS: mWeb Safari
https://github.com/Expensify/App/assets/61014013/72bd11c0-98a2-4301-b82f-72e113f74492MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/61014013/8d222309-d4bf-48cb-b938-9ea2314a4909MacOS: Desktop
https://github.com/Expensify/App/assets/61014013/4f5c8b80-4683-455e-927b-0eac100357be