Closed nkdengineer closed 1 week ago
@s77rt Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and not onIconClick
).myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components using Avatar
have been tested & I retested again)/** comment above it */
this
properly so there are no scoping issues (i.e. for onClick={this.submit}
the method this.submit
should be bound to this
in the constructor)this
are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this);
if this.submit
is never passed to a component event handler like onClick
)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG
)Avatar
is modified, I verified that Avatar
is working as expected in all cases)Design
label and/or tagged @Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test
steps.:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.
🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.71-6 🚀
platform | result |
---|---|
🤖 android 🤖 | success ✅ |
🖥 desktop 🖥 | success ✅ |
🍎 iOS 🍎 | success ✅ |
🕸 web 🕸 | success ✅ |
Details
Fix cannot create task for new user via [] method
Fixed Issues
$ https://github.com/Expensify/App/issues/40518 PROPOSAL: https://github.com/Expensify/App/issues/40518#issuecomment-2065884551
Tests
Offline tests
Same as above
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
https://github.com/Expensify/App/assets/161821005/14dc4d07-09c5-416e-a65b-b9e28cf224d4Android: mWeb Chrome
https://github.com/Expensify/App/assets/161821005/9acbe8e9-ac99-4edc-81d5-722b1597c844iOS: Native
https://github.com/Expensify/App/assets/161821005/66112b94-cb80-4d4d-832f-af92a93a9f74iOS: mWeb Safari
https://github.com/Expensify/App/assets/161821005/0af3d1ea-2aeb-4de0-95e8-0a6aacc79d4fMacOS: Chrome / Safari
https://github.com/Expensify/App/assets/161821005/0c0a8097-9b4a-4014-8ee3-60680eddc182MacOS: Desktop
https://github.com/Expensify/App/assets/161821005/b7e8d795-0b5a-460b-bc09-6a380cf082ef