Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
2.99k stars 2.5k forks source link

[CRITICAL] [VIP Travel] Handle tripName updates to display Trip Title and dates in newDot #41207

Open twisterdotcom opened 2 weeks ago

twisterdotcom commented 2 weeks ago

We need to display a Trip Title on newDot, but we weren't getting it with just PNR updates (which we decided to get here).

We asked Spotnana to send us both the trip_v3 webhooks and PNR webhooks. We'll be receiving the PNR data with the trip_v3 webhooks, which we should ignore. We'll take the trip data and always update the trip title:

image

...from the data returned via the trip_v3 web hook:

{
"tripId": "6926658168",
"tripName": "JFK SFO Trip",
"tripDescription": "JFK SFO Business Trip",
"applicationId": "97ab27fa-30e2-43e3-92a3-160e80f4c0d5",
"startDate": {
"iso8601": "2017-07-21"
},
"endDate": {
"iso8601": "2017-07-21"
}
}
melvin-bot[bot] commented 2 weeks ago

Auto-assigning issues to engineers is no longer supported. If you think this issue should receive engineering attention, please raise it in #whatsnext.

melvin-bot[bot] commented 2 weeks ago

Auto-assigning issues to engineers is no longer supported. If you think this issue should receive engineering attention, please raise it in #whatsnext.

melvin-bot[bot] commented 2 weeks ago

@danieldoglas Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

danieldoglas commented 2 weeks ago

will deal with this during the weekend probably

danieldoglas commented 1 week ago

This should be ready to review

melvin-bot[bot] commented 5 days ago

@danieldoglas Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

danieldoglas commented 5 days ago

should go with the next deploy

danieldoglas commented 3 days ago

The auth part was deployed, this should be returned to the API now https://github.com/Expensify/Auth/pull/10793