Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.32k stars 2.76k forks source link

[$250] Chats don’t load when logging in using Google SSO from public room banner. #41246

Closed m-natarajan closed 1 month ago

m-natarajan commented 4 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.67-2 Reproducible in staging?: Yes Reproducible in production?: yes If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @garrettmknight Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1714391455919649

Action Performed:

  1. Go to staging on Chrome - log out if you need to
  2. Access public room - https://staging.new.expensify.com/r/2376199970894587
  3. Navigate to the self DM that populates in LHN
  4. Click ‘Sign in’ in the banner
  5. Sign in w/ Google

    Expected Result:

    Your signed in profile’s chats load

    Actual Result:

    No additional chats load, ‘Hmm…’ flashes

    Workaround:

    Unknown

    Platforms:

    Which of our officially supported platforms is this issue occurring on?

    • [ ] Android: Native
    • [ ] Android: mWeb Chrome
    • [ ] iOS: Native
    • [ ] iOS: mWeb Safari
    • [X] MacOS: Chrome / Safari
    • [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/38435837/faf8e560-0869-4fd9-b9ab-f7ac8ed5156a

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0140408c8876b6a1dd
  • Upwork Job ID: 1785085627943718912
  • Last Price Increase: 2024-05-14
  • Automatic offers:
    • alitoshmatov | Reviewer | 0
Issue OwnerCurrent Issue Owner: @cristipaval
flodnv commented 2 months ago

No update, I'm focused on more important tasks.

alitoshmatov commented 2 months ago

I don't have anything to add to @rezkiy37 's findings

rezkiy37 commented 2 months ago

Hello! FYI: I have a vacation from 11.07 to 26.07. Meanwhile, someone from Callstack can help with this issue.

muttmuure commented 2 months ago

Unassigning while Michael is out

muttmuure commented 2 months ago

If Flo is working on #fast-apis then let's ask someone else to work on this internally

melvin-bot[bot] commented 1 month ago

Triggered auto assignment to @jasperhuangg (AutoAssignerNewDotQuality)

lschurr commented 1 month ago

Hey @jasperhuangg - let me know if this is something you have the space to pick up. Thanks!

jasperhuangg commented 1 month ago

Hmm my plate is pretty full at the moment, sorry!

lschurr commented 1 month ago

Talking in the original Slack thread - Still trying to get an engineer assigned. https://expensify.slack.com/archives/C049HHMV9SM/p1714391455919649

melvin-bot[bot] commented 1 month ago

Triggered auto assignment to @cristipaval (AutoAssignerNewDotQuality)

cristipaval commented 1 month ago

I'll look into this one today.

garrettmknight commented 1 month ago

I can't reproduce this anymore - the original link to the public room is on a deleted workspace so I used a new public room.

  1. Go to staging on Chrome - log out if you need to
  2. Access public room - https://staging.new.expensify.com/r/6997181192654972
  3. Navigate to the self DM that populates in LHN
  4. Click ‘Sign in’ in the banner
  5. Sign in w/ Google

https://github.com/user-attachments/assets/837da8d2-4834-4025-b248-1fe9d31913e4

m-natarajan commented 1 month ago

Issue reproducible

https://github.com/user-attachments/assets/5422df9e-0cc3-4ef1-a46d-aedf2ec8554f

cristipaval commented 1 month ago

my top priority today. I'll first try to reproduce in my local env.

puneetlath commented 1 month ago

Wait, I don't follow. From looking at that video, it seems like everything worked, no?

cristipaval commented 1 month ago

As far as I understand, the problem is that the chats that should come in the LHN don't appear.

puneetlath commented 1 month ago

Ohh I see.

cristipaval commented 1 month ago

Okay, interesting bug! The app's wrong behavior is because we haven't implemented anonymous account claiming when signing with Google/Apple SSO. It was implemented only for regular sign-in.

The backend PRs are ready for review: Web-E and Auth.

cristipaval commented 1 month ago

The fix is in production. Is there any payment due for this issue or should we just close?

rezkiy37 commented 1 month ago

I am a contractor from Callstack. So no payments for me.

lschurr commented 1 month ago

I think we're good to close. Thanks @cristipaval!