search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.54k stars 2.88k forks source link

[Refactor][QBO] Handle better translation keys #41248

Closed aldo-expensify closed 2 weeks ago

aldo-expensify commented 6 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: Reproducible in staging?: Reproducible in production?: If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Slack conversation:

@luacmartins suggested to use translateIfPhraseKey for stages

Context: https://expensify.slack.com/archives/C03TQ48KC/p1714421484252409?thread_ts=1714421087.411779&cid=C03TQ48KC

Action Performed:

N/A

Expected Result:

N/A

Actual Result:

N/A

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01065d2b3f47c96271
  • Upwork Job ID: 1785040300946468864
  • Last Price Increase: 2024-04-29
melvin-bot[bot] commented 6 months ago

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] commented 6 months ago

Job added to Upwork: https://www.upwork.com/jobs/~01065d2b3f47c96271

melvin-bot[bot] commented 6 months ago

Triggered auto assignment to Contributor Plus for review of internal employee PR - @jayeshmangwani (Internal)

melvin-bot[bot] commented 6 months ago

Current assignee @isabelastisser is eligible for the NewFeature assigner, not assigning anyone new.

melvin-bot[bot] commented 6 months ago

:warning: It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time :warning:

melvin-bot[bot] commented 6 months ago

Triggered auto assignment to Design team member for new feature review - @shawnborton (NewFeature)

aldo-expensify commented 6 months ago

Sorry, removing everyone, this is not a Bug , it is just a simple code refactor

aldo-expensify commented 6 months ago

No updates yet, focusing on helping with the fire

aldo-expensify commented 5 months ago

sames as before

aldo-expensify commented 5 months ago

sames as before

aldo-expensify commented 5 months ago

sames as before

aldo-expensify commented 3 months ago

Coming back from being OOO, I'll try to put some time on this this week.

aldo-expensify commented 2 months ago

No progress yet

aldo-expensify commented 1 month ago

No progress yet

aldo-expensify commented 2 weeks ago

The function translateIfPhraseKey doesn't exist anymore. I search for something similar in our code and didn't find.

I looked into the en.ts file and there are already a few other cases where we have a function with a switch to handle translation.

I'm ok with the current design and using en.ts because it keeps the translations in the same file and it is pretty readable IMO, so I'm just going to close this.