Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
2.99k stars 2.5k forks source link

[No QA] Update rates to match backend for latest research #41269

Closed neil-marcellini closed 1 week ago

neil-marcellini commented 2 weeks ago

Details

Fixed Issues

https://github.com/Expensify/App/issues/36974

Tests

Test steps are from the related Web-E PR

  1. Log in to OldDot with a test account
  2. Go to you personal policy > Reports
  3. Update the report currency to EUR
  4. Log in to NewDot with the same account
  5. Create a distance expense
  6. Submit it to an individual
  7. Verify the rate displays as 30 cents in Euros on the confirmation page
  8. Save the expense
  9. Verify the rate is correct after creation too

Offline tests

N/A

QA Steps

Same as tests

PR Author Checklist

Screenshots/Videos

Only tested on Chrome since changes are platform independent.

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari https://github.com/Expensify/App/assets/26260477/a5c107af-f20b-4ef8-adf2-649d7d186c9e
MacOS: Desktop
melvin-bot[bot] commented 2 weeks ago

@chiragsalian Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

neil-marcellini commented 2 weeks ago

No C+ needed. I'll request an internal review from whoever is assigned to the backend PR.

Beamanator commented 2 weeks ago

Reviewer Checklist

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop
Beamanator commented 1 week ago

https://github.com/Expensify/Web-Expensify/pull/41742 was deployed to prod 4 days ago so this can probs be off hold :D

OSBotify commented 1 week ago

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify commented 1 week ago

πŸš€ Deployed to production by https://github.com/marcaaron in version: 1.4.71-6 πŸš€

platform result
πŸ€– android πŸ€– success βœ…
πŸ–₯ desktop πŸ–₯ success βœ…
🍎 iOS 🍎 success βœ…
πŸ•Έ web πŸ•Έ success βœ