Closed tienifr closed 5 days ago
@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
@shubham1206agra any updates?
@tienifr Can you merge main?
@tienifr Bump on this.
@shubham1206agra merged main. We're good to go
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and not onIconClick
).myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components using Avatar
have been tested & I retested again)/** comment above it */
this
properly so there are no scoping issues (i.e. for onClick={this.submit}
the method this.submit
should be bound to this
in the constructor)this
are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this);
if this.submit
is never passed to a component event handler like onClick
)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG
)Avatar
is modified, I verified that Avatar
is working as expected in all cases)Design
label and/or tagged @Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test
steps.:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.
π Deployed to staging by https://github.com/robertjchen in version: 1.4.74-0 π
platform | result |
---|---|
π€ android π€ | success β |
π₯ desktop π₯ | success β |
π iOS π | success β |
πΈ web πΈ | success β |
Details
Fixed Issues
$ https://github.com/Expensify/App/issues/40205 PROPOSAL: https://github.com/Expensify/App/issues/40205#issuecomment-2060933691
Tests
@tienifr
and hit send (Make sure to use "`" to make it a codeblock)@tienifr
is shownOffline tests
Same as above
QA Steps
@tienifr
and hit send (Make sure to use "`" to make it a codeblock)@tienifr
is shownPR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
https://github.com/Expensify/App/assets/113963320/56044c69-0e80-4597-ab51-b316dd333667Android: mWeb Chrome
https://github.com/Expensify/App/assets/113963320/909fe45e-6773-4f39-9b61-f8ed0d4c4be7iOS: Native
https://github.com/Expensify/App/assets/113963320/7d85b042-ea89-462a-91c7-3673efaf5069iOS: mWeb Safari
https://github.com/Expensify/App/assets/113963320/4c9e5d2b-8704-4ab9-9e02-3f8683792ccfMacOS: Chrome / Safari
https://github.com/Expensify/App/assets/113963320/1c4102c5-7f63-4562-b7b9-bfe39aefdb1eMacOS: Desktop
https://github.com/Expensify/App/assets/113963320/503e09cd-869d-4939-85fe-82e5213284c1