[$250] Workspace - Workspace name is truncated inconsistently in mWeb and android

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.68 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team

Action Performed:

1. Open mweb and android app
2. Tap profile --- Workspaces---new Workspace
3. Tap profile
4. Paste text in both mweb and app-RtTest Workspace testingtestingtestingtestingtestingtestinggghhhhhhggggggf722222222222mmmmmmmmmmmmm7

Expected Result:

Workspace name truncated must be consistent in mweb and android

Actual Result:

Workspace name is truncated inconsistently in mweb and android

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [x] Android: Native
• [x] Android: mWeb Chrome
• [ ] iOS: Native
• [ ] iOS: mWeb Safari
• [ ] MacOS: Chrome / Safari
• [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0106a5ae69cbfb2cf2
• Upwork Job ID: 1785354421533896704
• Last Price Increase: 2024-04-30
• Automatic offers:
• getusha | Reviewer | 0
• Krishna2323 | Contributor | 0

Issue Owner

Current Issue Owner: @getusha

[melvin-bot[bot]]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@garrettmknight FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-vsp

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~0106a5ae69cbfb2cf2

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (External)

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace - Workspace name is truncated inconsistently in mWeb and android

What is the root cause of that problem?

The title doesn't take the full width because flex1 isn't applied to workspaceTitleStyle. https://github.com/Expensify/App/blob/1abad69fa3e3144c0a0959be8e57fbba5cc639a5/src/styles/index.ts#L4851-L4854

What changes do you think we should make in order to solve the problem?

Apply flex:1/styles.flex1 to workspaceTitleStyle style object and also check for similar issues in other fields.

What alternative solutions did you explore? (Optional)

Add flex1 to menu item title and description if needed.

Before

https://github.com/Expensify/App/assets/85894871/7b71f4d4-c191-4154-b0e6-1b598c3e6cfe

After

https://github.com/Expensify/App/assets/85894871/675e4db8-8f33-4a63-b99f-4658b4c5d090

[Krishna2323]

Proposal Updated

• Added alternative
• Added fix videos

[getusha]

@tienifr didn't we fix this before?

[tienifr]

@getusha Hmm I'm not sure, I've been working on many PRs relating to truncation. Could you link the PR you mentioned?

[getusha]

@tienifr here, this one https://github.com/Expensify/App/pull/40824 I copied your PR to fix some conflicts.

[tienifr]

I think we missed that case on Android, the PR was merged too fast. But this issue is external and the solution from @Krishna2323 will fix the issue. Should we fix that problem here? @getusha

[getusha]

Actually after a closer look, looks like it's on a different place. Workspace profile and Workspace list.

[getusha]

@Krishna2323 why was this happening only on android native?

[Krishna2323]

@getusha, this is a known issue in android native, the text component doesn't fill up the space automatically. We have already applied flex1 to fix this issue in many places, e.g., https://github.com/Expensify/App/issues/30222.

[getusha]

@Krishna2323's proposal looks good to me 🎀 👀 🎀 C+ Reviewed!

[melvin-bot[bot]]

Triggered auto assignment to @hayata-suenaga, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[hayata-suenaga]

I agree that @Krishna2323's proposal looks good.

[melvin-bot[bot]]

📣 @getusha 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job

[melvin-bot[bot]]

📣 @Krishna2323 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

[Krishna2323]

@getusha, PR ready for review.