search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
2.99k stars 2.5k forks source link

[HOLD for payment 2024-05-20] [$250] Whispered messages showing to all users temporarily when scrolling #41464

Open m-natarajan opened 2 weeks ago

m-natarajan commented 2 weeks ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: Reproducible in staging?: needs reproduction Reproducible in production?: needs reproduction If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @zsgreenwald Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1714505816123539

Action Performed:

  1. Open any public room
  2. Scroll the page up and down

Expected Result:

only the whispered messages intended for you are displayed

Actual Result:

whispered messages intended to someone else are displayed

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/38435837/46b3c3f4-6813-4713-9e0b-72297dd8b47f

https://github.com/Expensify/App/assets/38435837/9de8ca5f-86c9-4e4b-9853-334528ac0663

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01afb8dc7580ba1380
  • Upwork Job ID: 1787563116814917632
  • Last Price Increase: 2024-05-06
Issue OwnerCurrent Issue Owner: @sonialiap
melvin-bot[bot] commented 2 weeks ago

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

MelvinBot commented 2 weeks ago

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

marcaaron commented 1 week ago

Chatting about this in Slack and it seems like this can be fixed Externally. We need to deprecate reportAction.whisperedToAccountIDs and use reportAction.message.whisperedTo instead (which as far as we can tell is always the same).

We are deprecating reportAction.originalMessage in this issue. One way to migrate this would be something like:

if (isObject(reportAction.message)) {
    whisperedToAccountIDs = reportAction.message?.whisperedTo ?? [];
} else {
    whisperedToAccountIDs = reportAction?.originalMessage?.whisperedTo ?? [];
}

We can come back later to remove the originalMessage fallback once the Internal part of the linked issue is done.

There is some Internal backend cleanup to do as well since we have whisperedToAccountIDs being sent for at least one spot in Auth here.

@luacmartins also noticed there are som missing keys when sending updates via Auth (which should be fixed, but unclear if causing any specific problem for New Dot). But maybe we can create a separate issue for that since it does not seem related to this bug.

melvin-bot[bot] commented 1 week ago

Job added to Upwork: https://www.upwork.com/jobs/~01afb8dc7580ba1380

melvin-bot[bot] commented 1 week ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jayeshmangwani (External)

melvin-bot[bot] commented 1 week ago

Current assignee @jayeshmangwani is eligible for the Internal assigner, not assigning anyone new.

marcaaron commented 1 week ago

Working on this as we need it quick - still a front end change for now.

melvin-bot[bot] commented 6 days ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 6 days ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.72-1 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-05-20. :confetti_ball:

For reference, here are some details about the assignees on this issue:

melvin-bot[bot] commented 6 days ago

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed: