Open nkdengineer opened 2 weeks ago
@akinwale Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
@akinwale Friendly bump.
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and not onIconClick
).myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components using Avatar
have been tested & I retested again)/** comment above it */
this
properly so there are no scoping issues (i.e. for onClick={this.submit}
the method this.submit
should be bound to this
in the constructor)this
are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this);
if this.submit
is never passed to a component event handler like onClick
)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG
)Avatar
is modified, I verified that Avatar
is working as expected in all cases)Design
label and/or tagged @Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test
steps.Nice job. You have conflicts now though. Please merge main.
@puneetlath I merged main.
Typescript check is failing.
@puneetlath This fails on main, merged latest main to fix this.
Details
Add error for failure invited member
Fixed Issues
$ https://github.com/Expensify/App/issues/39495 https://github.com/Expensify/App/issues/41133 PROPOSAL: https://github.com/Expensify/App/issues/39495#issuecomment-2045422039
Tests
Precondition: Create a room in a workspace
+18183305299
and invite the userOffline tests
None
QA Steps
Precondition: Create a room in a workspace
+18183305299
and invite the userPR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
https://github.com/Expensify/App/assets/161821005/9e61dec3-1ec4-4b31-9dd6-971e60f3ee64Android: mWeb Chrome
https://github.com/Expensify/App/assets/161821005/62c62abe-b48a-41f0-bac3-0ed60e738607iOS: Native
https://github.com/Expensify/App/assets/161821005/866b525e-a3bb-4163-88b3-696d5a446e1ciOS: mWeb Safari
https://github.com/Expensify/App/assets/161821005/dbaeb2db-04be-4745-810f-a890fc4fbaa7MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/161821005/3ed4c497-25b0-4f40-a0bc-4782fe3e55e7 https://github.com/Expensify/App/assets/161821005/214503a2-1994-4ca5-95f6-020526c5af15MacOS: Desktop
https://github.com/Expensify/App/assets/161821005/26290acf-2536-40ee-b9fa-38dbd565ccbe