Closed lakchote closed 1 week ago
@mollfpr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
English translations:
case 'xeroSyncImportChartOfAccounts':
return 'Syncing chart of accounts';
case 'xeroSyncImportCategories':
return 'Syncing categories';
case 'xeroSyncImportCustomers':
return 'Syncing customers';
case 'xeroSyncXeroReimbursedReports':
return 'Marking Expensify reports as reimbursed';
case 'xeroSyncExpensifyReimbursedReports':
return 'Marking Xero bills and invoices as paid';
case 'xeroSyncImportTrackingCategories':
return 'Syncing tracking categories';
case 'xeroSyncImportBankAccounts':
return 'Syncing bank accounts';
case 'xeroSyncImportTaxRates':
return 'Syncing tax rates';
case 'xeroCheckConnection':
return 'Checking Xero connection';
case 'xeroSyncTitle':
return 'Synchronizing Xero data';
case 'xeroSyncStep':
return 'Loading data';
Spanish translations (with DeepL):
case 'xeroSyncImportChartOfAccounts':
return 'Sincronizando chart of accounts';
case 'xeroSyncImportCategories':
return 'Sincronizando categories';
case 'xeroSyncImportCustomers':
return 'Sincronizando customers';
case 'xeroSyncXeroReimbursedReports':
return 'Marcar Expensify reports como reimbursed';
case 'xeroSyncExpensifyReimbursedReports':
return 'Marcar Xero bills y invoices como paid';
case 'xeroSyncImportTrackingCategories':
return 'Sincronizando tracking categories';
case 'xeroSyncImportBankAccounts':
return 'Sincronizando bank accounts';
case 'xeroSyncImportTaxRates':
return 'Sincronizando tax rates';
case 'xeroCheckConnection':
return 'Comprobando conexiΓ³n Xero';
case 'xeroSyncTitle':
return 'Sincronizando datos Xero';
case 'xeroSyncStep':
return 'Cargando datos';
Do the spanish translations look correct to you?
@pecanoro could you please take a look at the translations just above? Thanks!
Can you add the translations to the file so I can leave suggestions? π
Can you add the translations to the file so I can leave suggestions? π
Done here π
Thank you Rocio!
cc @rushatgabhane ready for review
@rushatgabhane All yours!
@lakchote Do we need to change the main branch of this one as well?
@lakchote Do we need to change the main branch of this one as well?
Yes, a big YES! I've thought about it for my other Xero PR, but forgot about this one. Thank you!
@rushatgabhane Friendly bump!
@lakchote I am testing Sync now on Xero and I am assuming the translations/stages will be fixed here when the user clicks sync button? When do you think we'll have this merged?
https://github.com/Expensify/App/assets/3069065/00c7cb4d-a99f-4830-99b4-6ea72b2c52bd
@lakchote I am testing Sync now on Xero and I am assuming the translations/stages will be fixed here when the user clicks sync button? When do you think we'll have this merged?
Yes it'll be fixed when this PR gets merged. We are waiting for @rushatgabhane's approval.
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and not onIconClick
).myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components using Avatar
have been tested & I retested again)/** comment above it */
this
properly so there are no scoping issues (i.e. for onClick={this.submit}
the method this.submit
should be bound to this
in the constructor)this
are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this);
if this.submit
is never passed to a component event handler like onClick
)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG
)Avatar
is modified, I verified that Avatar
is working as expected in all cases)Design
label and/or tagged @Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test
steps.π Deployed to staging by https://github.com/pecanoro in version: 1.4.74-0 π
platform | result |
---|---|
π€ android π€ | success β |
π₯ desktop π₯ | success β |
π iOS π | success β |
πΈ web πΈ | success β |
Details
Fixed Issues
$ https://github.com/Expensify/App/issues/41486 PROPOSAL:
Tests
Accounting
and click onSet up
for XeroVideo:
https://github.com/Expensify/App/assets/21549771/00359807-61b6-494c-bebc-e5209fe2cbf7
Offline tests
NA
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/21549771/00359807-61b6-494c-bebc-e5209fe2cbf7MacOS: Desktop