Open lanitochka17 opened 2 weeks ago
Triggered auto assignment to @kadiealexander (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
@kadiealexander FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
We think that this bug might be related to #vip-vsp
The draft text isn't cleared when we delete the message from another report screen.
When we leave a thread, it will navigate to the most recent report (except the current report). https://github.com/Expensify/App/blob/7483d10e686e240d07d9fa3e43e89ffdfcda9cbd/src/libs/actions/Report.ts#L2508-L2515
So, now there are 2 same reports in the navigation stack. If we clear the composer message from the 2nd report screen and go back, the 1st report screen will still show the composer message. It's because the onyx draft message and the composer message state aren't synchronized.
This doesn't happen on other platforms because we have an effect to sync it. https://github.com/Expensify/App/blob/7483d10e686e240d07d9fa3e43e89ffdfcda9cbd/src/pages/home/report/ReportActionCompose/SilentCommentUpdater/index.tsx#L25-L37
But we don't have it for Android (it was removed in https://github.com/Expensify/App/pull/32799) https://github.com/Expensify/App/blob/7483d10e686e240d07d9fa3e43e89ffdfcda9cbd/src/pages/home/report/ReportActionCompose/SilentCommentUpdater/index.android.tsx#L16-L23
We can update the navigate to the most recent report logic to just use goBack with the report screen as the fallback https://github.com/Expensify/App/blob/7483d10e686e240d07d9fa3e43e89ffdfcda9cbd/src/libs/actions/Report.ts#L2508-L2515
Navigation.goBack(lastAccessedReportRoute);
This will make sure we won't have 2 same report screens in the stack, so we don't need to sync the composer message state.
Job added to Upwork: https://www.upwork.com/jobs/~01321f2f43059fc592
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External
)
@mollfpr please review the proposal above, thanks!
@bernhardoj I don't understand the changes you suggest, the permalink you attach already uses Navigation.goBack(lastAccessedReportRoute);
.
Navigation.goBack(lastAccessedReportRoute);
will only be called if it's not a thread, but in our case, we leave a thread.
@mollfpr, @kadiealexander Whoops! This issue is 2 days overdue. Let's get this updated quick!
The proposal from @bernhardoj makes sense to me and I have tested the solution it's fixed the issue.
π π π C+ reviewed!
Triggered auto assignment to @NikkiWines, see https://stackoverflow.com/c/expensify/questions/7972 for more details.
Yep, agreed - thanks for the proposal @bernhardoj π
π£ @bernhardoj π An offer has been automatically sent to your Upwork account for the Contributor role π Thanks for contributing to the Expensify app!
Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review π§βπ» Keep in mind: Code of Conduct | Contributing π
PR is ready
cc: @mollfpr
If you havenβt already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.69-2 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team
Action Performed:
Expected Result:
The compose box doesn't contain any draft text
Actual Result:
The compose box contains the previously cleared draft text
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/78819774/80f26b98-b112-45e5-aa2b-bb8398ad5e0c
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @NikkiWines