Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.33k stars 2.76k forks source link

[$500] IOU not showing up after split #41533

Open m-natarajan opened 4 months ago

m-natarajan commented 4 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: Reproducible in staging?: needs reproduction Reproducible in production?: needs reproduction If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @danielrvidal Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1714137578957479

Action Performed:

  1. Open app and login as User A
  2. User B split expense with user A in group DM

Expected Result:

User sees a GBR or DM/ IOU from user B

Actual Result:

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence image (27)

image (12)

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01c8a232784bbc38ae
  • Upwork Job ID: 1789994484340371456
  • Last Price Increase: 2024-05-31
melvin-bot[bot] commented 4 months ago

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

MelvinBot commented 4 months ago

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

sonialiap commented 4 months ago

Assigned to me after hours and I'm OOO Fri and Mon, reassigning so it doesn't get moldy

melvin-bot[bot] commented 4 months ago

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] commented 4 months ago

@greg-schroeder Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

greg-schroeder commented 4 months ago

Pinging QA for a re-test

greg-schroeder commented 4 months ago

Also adding to split project

kbecciv commented 4 months ago

Issue is reproducible on Win11Pro/Chrome - v1.4.72-0

https://github.com/Expensify/App/assets/93399543/f25d9034-3156-4d7a-8136-be841a7ef862

melvin-bot[bot] commented 4 months ago

Job added to Upwork: https://www.upwork.com/jobs/~01c8a232784bbc38ae

greg-schroeder commented 4 months ago

Okay sending through to External

melvin-bot[bot] commented 4 months ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-djouah (External)

jnowakow commented 4 months ago

May be connected to this issue

melvin-bot[bot] commented 4 months ago

@greg-schroeder @rayane-djouah this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

melvin-bot[bot] commented 4 months ago

@greg-schroeder, @rayane-djouah Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

rayane-djouah commented 4 months ago

This may be a backend bug as stated in https://github.com/Expensify/App/issues/41260#issuecomment-2111516351, it may be fixed now. This needs reproduction.

rayane-djouah commented 4 months ago

@kbecciv, @m-natarajan Could you please confirm if this is still reproducible?

melvin-bot[bot] commented 3 months ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

rayane-djouah commented 3 months ago

Issue needs reproduction

greg-schroeder commented 3 months ago

I couldn't repro either ... checking w/ QA and we can potentially close

https://expensify.slack.com/archives/C9YU7BX5M/p1716337450256539

kavimuru commented 3 months ago

Reproducible if there is no conversation between the account.

https://github.com/Expensify/App/assets/43996225/9f583500-bb75-4c64-9a7c-ed4053157de5

greg-schroeder commented 3 months ago

Got it, thanks @kavimuru

greg-schroeder commented 3 months ago

Updated

rayane-djouah commented 3 months ago

Heads up, I'll be mostly offline until June 5th, 2024. I can still review this issue, but my response might be slower. If there is something urgent, please reassign it. Thanks!

melvin-bot[bot] commented 3 months ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

rayane-djouah commented 3 months ago

Waiting on proposals

melvin-bot[bot] commented 3 months ago

@greg-schroeder @rayane-djouah this issue is now 4 weeks old, please consider:

Thanks!

melvin-bot[bot] commented 3 months ago

@greg-schroeder, @rayane-djouah Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] commented 3 months ago

Upwork job price has been updated to $500

mallenexpensify commented 3 months ago

Raised price to $500 to try to get some proposals. It might be hard because reproduction steps might not be specific-enough for a contributor to reliably reproduce. If we don't get action here in a few days we can discuss compensating for reliable reproduction steps.

Below might also be related, we recently got reproduction steps for that, in case they're helpful here.

cc @saracouto

greg-schroeder commented 3 months ago

Thanks @mallenexpensify

SzymczakJ commented 3 months ago

Hey! I’m Jakub Szymczak from Software Mansion, an expert agency, and I’d like to work on this issue! I will be able to start this tomorrow 😄

greg-schroeder commented 3 months ago

Thanks @SzymczakJ!

saracouto commented 3 months ago

FYI - I just experienced this today while testing a split!

rayane-djouah commented 3 months ago

I will be OOO until june 12th, feel free to reassign another C+ if you prefer.

SzymczakJ commented 3 months ago

After investigating for some time I noticed strange behaviour:

  1. As user A I create group with user B(they don't have any previous connections or chats together) and I create a split expense on this group. At this point user A sees the split IOU. This is the chat report data that's present in user A onyx store that allows this report to be shown:

    Screenshot 2024-06-05 at 20 01 47

    please notice that reportID is "report_8850932074352690"

  2. On the other hand user B doesn't see this IOU. He has the same chat report entry in onyx store but this report entry is missing a lot of data:

    Screenshot 2024-06-05 at 20 03 33

    this reportID is also "report_8850932074352690"

  3. After that I find user A as a user B and click on chat with him(see the video) and suddenly a IOU pops up on LHN

https://github.com/Expensify/App/assets/88395093/445fb683-abdb-49fe-ad59-2ab600a9c96e

Now the user B has the same data of this specific report as user A:

Screenshot 2024-06-05 at 20 21 07

I don't see any operation that would run on front end that could possibly update this report on user B side. The only thing that frontend does is running OpenReport and OpenPaymentsPage API commands. After the invocation of these two commands correct data for chat report pops up, so my guess is that initially BE does something wrong. Can somebody from backend take a look at this? cc @greg-schroeder

greg-schroeder commented 3 months ago

Standby @SzymczakJ

greg-schroeder commented 3 months ago

@thienlnam confirms, moving Internal then

melvin-bot[bot] commented 3 months ago

@greg-schroeder, @rayane-djouah Whoops! This issue is 2 days overdue. Let's get this updated quick!

greg-schroeder commented 3 months ago

Waiting for an Expensify engineer to take this

saracouto commented 3 months ago

Moving to monthly since split is being paused for the next few months

rayane-djouah commented 3 months ago

unassigning myself as this is internal

greg-schroeder commented 2 months ago

No update here

greg-schroeder commented 2 months ago

This is paused

greg-schroeder commented 1 month ago

Same as above

greg-schroeder commented 2 weeks ago

No update

greg-schroeder commented 1 week ago

Same as above