Closed gijoe0295 closed 1 week ago
@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
Hi @gijoe0295!
Can you please resolve conflicts?
@allroundexperts Done!
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and not onIconClick
).myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components using Avatar
have been tested & I retested again)/** comment above it */
this
properly so there are no scoping issues (i.e. for onClick={this.submit}
the method this.submit
should be bound to this
in the constructor)this
are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this);
if this.submit
is never passed to a component event handler like onClick
)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG
)Avatar
is modified, I verified that Avatar
is working as expected in all cases)Design
label and/or tagged @Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test
steps.:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.
π Deployed to staging by https://github.com/luacmartins in version: 1.4.73-0 π
platform | result |
---|---|
π€ android π€ | success β |
π₯ desktop π₯ | success β |
π iOS π | success β |
πΈ web πΈ | success β |
@luacmartins @allroundexperts @gijoe0295
All the screenshots provided don't follow the correct testing steps.
The provided screenshots seem to be testing workspaces with single-level tags. This PR seems to only disable the delete option for single-level tags, which is not what was requested here.
This is what a workspace with multi-level tags looks like:
The WorkspaceViewTagsPage
is what's used for multi-level tags, not the WorkspaceTagsPage
that's changed in this PR.
I'm going to revert this PR.
Ah, clarified with the contributor that the page didn't exist when they were implementing thisβthey will fix in a followup.
π Deployed to production by https://github.com/Beamanator in version: 1.4.73-7 π
platform | result |
---|---|
π€ android π€ | success β |
π₯ desktop π₯ | success β |
π iOS π | success β |
πΈ web πΈ | success β |
Details
This PR hides the delete option for multilevel tags.
Fixed Issues
$ https://github.com/Expensify/App/issues/38683 PROPOSAL: https://github.com/Expensify/App/issues/38683#issuecomment-2083477820
Tests
People must tag expenses
andUse multiple level of tags
Offline tests
NA
QA Steps
People must tag expenses
andUse multiple level of tags
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
![photo_2024-05-03_10-38-58](https://github.com/Expensify/App/assets/153004152/622a1fab-8587-46c0-92bd-8820851fd83b) ![photo_2024-05-03_10-38-55](https://github.com/Expensify/App/assets/153004152/10f5fdf4-1e52-480a-89c6-0e8ba4770a9b)Android: mWeb Chrome
![photo_2024-05-03_10-28-56](https://github.com/Expensify/App/assets/153004152/289d0605-f31f-4acd-b119-99813a446d08) ![photo_2024-05-03_10-28-54](https://github.com/Expensify/App/assets/153004152/c2f1e190-64af-4892-91c5-9798d4921a60)iOS: Native
![Simulator Screenshot - iPhone 15 Pro Max - 2024-05-03 at 10 04 01](https://github.com/Expensify/App/assets/153004152/6b3fd9e6-5e12-4e06-a7b7-b7f083e50736) ![Simulator Screenshot - iPhone 15 Pro Max - 2024-05-03 at 10 04 05](https://github.com/Expensify/App/assets/153004152/f4c2bae9-8130-4c2b-a57a-0c0265b6499e)iOS: mWeb Safari
![Simulator Screenshot - iPhone 15 Pro Max - 2024-05-03 at 09 59 56](https://github.com/Expensify/App/assets/153004152/dd451fff-6d8d-43ff-9378-7990f7b45d2c) ![Simulator Screenshot - iPhone 15 Pro Max - 2024-05-03 at 10 00 00](https://github.com/Expensify/App/assets/153004152/bf311e4a-38c5-46ae-858b-2304b1e33e3b)MacOS: Chrome / Safari
MacOS: Desktop