Closed nkdengineer closed 1 week ago
@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and not onIconClick
).myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components using Avatar
have been tested & I retested again)/** comment above it */
this
properly so there are no scoping issues (i.e. for onClick={this.submit}
the method this.submit
should be bound to this
in the constructor)this
are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this);
if this.submit
is never passed to a component event handler like onClick
)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG
)Avatar
is modified, I verified that Avatar
is working as expected in all cases)Design
label and/or tagged @Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test
steps.@nkdengineer The x
is not correctly aligned with rest of the menu items. Please fix.
@nkdengineer The x is not correctly aligned with rest of the menu items. Please fix.
@allroundexperts I updated.
@allroundexperts Any update here.
:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.
🚀 Deployed to staging by https://github.com/MariaHCD in version: 1.4.73-0 🚀
platform | result |
---|---|
🤖 android 🤖 | success ✅ |
🖥 desktop 🖥 | success ✅ |
🍎 iOS 🍎 | success ✅ |
🕸 web 🕸 | success ✅ |
🚀 Deployed to production by https://github.com/Beamanator in version: 1.4.73-7 🚀
platform | result |
---|---|
🤖 android 🤖 | success ✅ |
🖥 desktop 🖥 | success ✅ |
🍎 iOS 🍎 | success ✅ |
🕸 web 🕸 | success ✅ |
Details
Display error when deleting receipt failure
Fixed Issues
$ https://github.com/Expensify/App/issues/40552 PROPOSAL: https://github.com/Expensify/App/issues/40552#issuecomment-2071998200
Tests
Offline tests
None
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
https://github.com/Expensify/App/assets/161821005/7383ef48-c15f-4f42-8e6a-99a563cd50fbAndroid: mWeb Chrome
https://github.com/Expensify/App/assets/161821005/8c4177d8-5077-4036-a5f8-c59cf6f3c1b3iOS: Native
https://github.com/Expensify/App/assets/161821005/6b32807c-159e-490a-b70b-b2bbee62062biOS: mWeb Safari
https://github.com/Expensify/App/assets/161821005/a7773449-64ce-4dc0-b19d-5e0eb2937f87MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/161821005/144b2a6d-a2ea-40a9-84a0-2fe89f959b89MacOS: Desktop
https://github.com/Expensify/App/assets/161821005/7bc7762c-5927-4d5c-9c0a-e6b1c264979a