search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
2.99k stars 2.5k forks source link

[HOLD for payment 2024-05-20] [Wave Collect] [Xero] Fix the ConnectionLayout component #41560

Open lakchote opened 2 weeks ago

lakchote commented 2 weeks ago

Problem

The ConnectionLayout component has some extra padding issues which prevent other PRs from reusing it.

Please see discussion here.

Solution

Let's fix the component and refactor the other Xero PRs to use it.

hungvu193 commented 2 weeks ago

Taking a look 👀

melvin-bot[bot] commented 2 weeks ago

Triggered auto assignment to @carlosmiceli, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

melvin-bot[bot] commented 1 week ago

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

carlosmiceli commented 1 week ago

Hey @lakchote, sorry to bother you, but do I need to do something here?It seems reviewed and merged, right?

lakchote commented 1 week ago

Hey @lakchote, sorry to bother you, but do I need to do something here?It seems reviewed and merged, right?

Hi @carlosmiceli, yes nothing to do on your part here! You shouldn't have been assigned, I'm correcting the assignees list.

Also, not a blocker https://github.com/Expensify/App/issues/41754#issuecomment-2099225842

trjExpensify commented 1 week ago

https://github.com/Expensify/App/pull/41561 - deployed to prod 9 hours ago https://github.com/Expensify/App/pull/41660 - deployed to prod 9 hours ago https://github.com/Expensify/App/pull/41664 - deployed to staging 9 hours ago

Are payments going to be due here or is this just a regression clean-up issue from the original?

lakchote commented 1 week ago

41561 - deployed to prod 9 hours ago #41660 - deployed to prod 9 hours ago #41664 - deployed to staging 9 hours ago

Are payments going to be due here or is this just a regression clean-up issue from the original?

These are just follow-up clean ups/regressions fixes. No payments due here, in my opinion.

melvin-bot[bot] commented 5 days ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 5 days ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.72-1 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-05-20. :confetti_ball:

For reference, here are some details about the assignees on this issue: