Closed ShridharGoel closed 1 day ago
@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
@ShridharGoel Can you fix the lint issues?
@ShridharGoel The PR for the Sync command on the backend is on staging. Can you please add the code for sync and finish the PR?
Let me know once it's done and ready for review.
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and not onIconClick
).myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components using Avatar
have been tested & I retested again)/** comment above it */
this
properly so there are no scoping issues (i.e. for onClick={this.submit}
the method this.submit
should be bound to this
in the constructor)this
are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this);
if this.submit
is never passed to a component event handler like onClick
)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG
)Avatar
is modified, I verified that Avatar
is working as expected in all cases)Design
label and/or tagged @Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test
steps.just double checking, have Spanish translations been approved, right?
Reviewing shortly 👀
@hungvu193, I think this PR has been already been reviewed by another C+ 🤔
@hungvu193, I think this PR has been already been reviewed by another C+ 🤔
ah yeah, I only re-verify while Manan was out as we discuss here
@ShridharGoel there are conflicts, please solve them when you can. Thanks.
@lakchote Will update in a few hours.
@lakchote Will update in a few hours.
Any update? Thanks!
@ShridharGoel I can see lint errors. Can you please fix them? Also while we might have the merge freeze? Can you check this thread on priority for potential merge conflicts? We're aiming to merge this asap as it is blocking some of our testing flows.
@mananjadhav Sure.
Details
Add sync functionality in Xero connection.
Fixed Issues
$ https://github.com/Expensify/App/issues/41320 PROPOSAL: https://github.com/Expensify/App/issues/41320#issuecomment-2085354319
Tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
https://github.com/Expensify/App/assets/35566748/b6f23505-fb93-47b0-a728-c04892756e97iOS: Native
https://github.com/Expensify/App/assets/35566748/a6368483-3fe7-403b-951c-5992efa4818ciOS: mWeb Safari
https://github.com/Expensify/App/assets/35566748/42526c90-f86d-432c-9153-fc12e84dcf98MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/35566748/abe37704-d10f-4ded-825f-cc6ea775e41fMacOS: Desktop
https://github.com/Expensify/App/assets/35566748/2e5d5d84-b117-4ad7-8932-bee32edb2a12