Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
2.99k stars 2.5k forks source link

[$250] IOU - Green dot on LHN remains when cancel request #41566

Open izarutskaya opened 2 weeks ago

izarutskaya commented 2 weeks ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.70-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4536087&group_by=cases:section_id&group_order=asc&group_id=229063 Email or phone of affected tester (no customers): applausetester+gm196@applause.expensifail.com Logs: https://stackoverflow.com/c/expensify/questions/4856 Issue reported by: Applause-Internal team

Action Performed:

  1. User A crates 3 manual money request with User B
  2. User B pay the requests
  3. User A creates new manual request with User B
  4. User A delete the request
  5. Take a note of green dot on User B LHN when deleted request disappear

Expected Result:

Green dot should disappear

Actual Result:

Green dot on LHN remains when request is deleted

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

https://github.com/Expensify/App/assets/115492554/3a3f1f93-81d5-472a-ae2b-cf8e59192ee1

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~013596a2fc8e8f656e
  • Upwork Job ID: 1787797094777081856
  • Last Price Increase: 2024-05-07
Issue OwnerCurrent Issue Owner: @mananjadhav
melvin-bot[bot] commented 2 weeks ago

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

izarutskaya commented 2 weeks ago

We think this issue might be related to the #vip-vsb.

gijoe0295 commented 2 weeks ago

This seems to be a BE issue where Pusher did not set hasOutstandingChildRequest to false when A deleted the request.

melvin-bot[bot] commented 1 week ago

@dylanexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

dylanexpensify commented 1 week ago

reproduced!

melvin-bot[bot] commented 1 week ago

Job added to Upwork: https://www.upwork.com/jobs/~013596a2fc8e8f656e

melvin-bot[bot] commented 1 week ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

tsa321 commented 1 week ago

I think this is Back end issue. The pusher data has hasOutstandingChildRequest: true for the report. It must be false.

mananjadhav commented 1 week ago

@dylanexpensify Can we assign an internal engineer here? Looks like we'll need a BE fix.

melvin-bot[bot] commented 5 days ago

@mananjadhav, @dylanexpensify Huh... This is 4 days overdue. Who can take care of this?

melvin-bot[bot] commented 4 days ago

Current assignee @mananjadhav is eligible for the Internal assigner, not assigning anyone new.

dylanexpensify commented 4 days ago

@quinthar mind seeing if anyone is available for this on vip-vsb team?

dylanexpensify commented 4 days ago

@mananjadhav put internal!

melvin-bot[bot] commented 3 days ago

@mananjadhav, @dylanexpensify 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

melvin-bot[bot] commented 1 day ago

@mananjadhav @dylanexpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

melvin-bot[bot] commented 1 day ago

@mananjadhav, @dylanexpensify 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!