Closed gijoe0295 closed 1 week ago
@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
@gijoe0295 I got this bug while recording the video for mSafari? Can you reproduce it?
https://github.com/Expensify/App/assets/16502320/2dce67a5-725e-4891-8c2d-e4387447c995
@hungvu193 Could you check if the action ID and the report ID in the URL are correct (i.e. point to the original report and action)? If yes then the issue you mentioned must be a different one and not related. I got it several times on main
.
mWeb safari is so broken for me, I'll try again in a while.
Ok, I can confirm it's not related to this PR.
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and not onIconClick
).myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components using Avatar
have been tested & I retested again)/** comment above it */
this
properly so there are no scoping issues (i.e. for onClick={this.submit}
the method this.submit
should be bound to this
in the constructor)this
are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this);
if this.submit
is never passed to a component event handler like onClick
)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG
)Avatar
is modified, I verified that Avatar
is working as expected in all cases)Design
label and/or tagged @Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test
steps.:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.
π Deployed to staging by https://github.com/techievivek in version: 1.4.72-0 π
platform | result |
---|---|
π€ android π€ | success β |
π₯ desktop π₯ | success β |
π iOS π | success β |
πΈ web πΈ | success β |
π Deployed to production by https://github.com/Beamanator in version: 1.4.72-1 π
platform | result |
---|---|
π€ android π€ | success β |
π₯ desktop π₯ | success β |
π iOS π | success β |
πΈ web πΈ | success β |
Details
Not here page displayed for deleted IOU link copied from 2nd level thread because it used the wrong
reportID
. This PR retrieves theoriginalReportID
instead.Fixed Issues
$ https://github.com/Expensify/App/issues/41091 PROPOSAL: https://github.com/Expensify/App/issues/41091#issuecomment-2079701685
Tests
Offline tests
NA
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
https://github.com/Expensify/App/assets/153004152/9c62ed57-fb66-425c-a372-b9a8637d32ecAndroid: mWeb Chrome
https://github.com/Expensify/App/assets/153004152/60ccdf16-d69c-4d4b-9677-f4a4f33f3c5fiOS: Native
https://github.com/Expensify/App/assets/153004152/e8cde880-27c9-4f9c-b325-e193905e7e0aiOS: mWeb Safari
https://github.com/Expensify/App/assets/153004152/c96bdd4c-56aa-4d50-854a-cb1694db3caaMacOS: Chrome / Safari
https://github.com/Expensify/App/assets/153004152/afabf684-d439-40c6-b878-88d49f7514fcMacOS: Desktop
https://github.com/Expensify/App/assets/153004152/b7ce66d1-9362-4db5-aab8-f6fd462b10de