Closed lakchote closed 1 week ago
@rushatgabhane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
cc @Expensify/design
The value under the push row label here shouldn't be bold - any idea what's going on there?
From Figma/design doc:
The value under the push row label here shouldn't be bold - any idea what's going on there?
Could you please post about it here since it doesn't concern this new page directly? Thanks!
@shawnborton it'll look like this for the Other integrations
style fix:
The regular weight text looks better, but we also should have a gap between the "Other integrations" row and the content above it, like so:
Also, Xero organization should also not be bold:
Check the mockup above. Thanks!
Style has now been fixed
https://github.com/Expensify/App/assets/21549771/76e0936a-9bf8-48d1-adb4-62d2dc0bb140
cc @rushatgabhane if you could review it :)
Could we have spanish translations for these please?
Thank you in advance!
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and not onIconClick
).myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components using Avatar
have been tested & I retested again)/** comment above it */
this
properly so there are no scoping issues (i.e. for onClick={this.submit}
the method this.submit
should be bound to this
in the constructor)this
are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this);
if this.submit
is never passed to a component event handler like onClick
)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG
)Avatar
is modified, I verified that Avatar
is working as expected in all cases)Design
label and/or tagged @Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test
steps.@roryabraham Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
Merging as @rushatgabhane has reviewed this PR, in order to move forward and avoid conflicts.
🚀 Deployed to staging by https://github.com/lakchote in version: 1.4.74-0 🚀
platform | result |
---|---|
🤖 android 🤖 | success ✅ |
🖥 desktop 🖥 | success ✅ |
🍎 iOS 🍎 | success ✅ |
🕸 web 🕸 | success ✅ |
We'll need the Xero export main page to be merged, in order to finalize this PR since its code depends on it.
Details
Fixed Issues
$ https://github.com/Expensify/App/issues/39743 PROPOSAL:
Tests
Prerequisite: having a valid Xero integration synced and connected
Accounting
pageExport
pageExport
page again, you should see the new value persistedVerify it works as expected.
Offline tests
Same as tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps./** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/21549771/f09a1fb4-acbd-41f3-9f36-a0831c27126aMacOS: Desktop