Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
2.99k stars 2.5k forks source link

Add support for viewing full screen Group Chat custom avatars #41586

Open nexarvo opened 2 weeks ago

nexarvo commented 2 weeks ago

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/39850 PROPOSAL: https://github.com/Expensify/App/issues/39850#issuecomment-2083897742

Tests

  1. Go to any group chat
  2. Click on the header
  3. Click on the chat avatar
  4. In the menu click on "View Photo"
  5. Verify that avatar opens in full screen and we can dismiss the modal by clicking "X".

Offline tests

QA Steps

  1. Go to any group chat
  2. Click on the header
  3. Click on the chat avatar
  4. In the menu click on "View Photo"
  5. Verify that avatar opens in full screen and we can dismiss the modal by clicking "X".

PR Author Checklist

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari https://github.com/Expensify/App/assets/53095363/fbb7d9dc-9dcd-4fdc-b7df-6c7c39b7703d
MacOS: Desktop
melvin-bot[bot] commented 2 weeks ago

@s77rt Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

s77rt commented 2 weeks ago

Also complete the checklist

nexarvo commented 1 week ago

@s77rt Need to confirm one thing, do we need to add "View Photo" functionality for starting a new group chat modal?

Screenshot 2024-05-06 at 7 07 30 PM
s77rt commented 1 week ago

Yes, let's add support for that one too

s77rt commented 1 week ago

@nexarvo Any update on this? Let me know if there is something blocking this

nexarvo commented 5 days ago

sorry for the delay. I will update and push the code for this by today EOD.

nexarvo commented 1 day ago

@s77rt can you please review this commit for this feature. Once approved I will test all the edge cases related to this.