Open nexarvo opened 2 weeks ago
@s77rt Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
Also complete the checklist
@s77rt Need to confirm one thing, do we need to add "View Photo" functionality for starting a new group chat modal?
Yes, let's add support for that one too
@nexarvo Any update on this? Let me know if there is something blocking this
Details
Fixed Issues
$ https://github.com/Expensify/App/issues/39850 PROPOSAL: https://github.com/Expensify/App/issues/39850#issuecomment-2083897742
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/53095363/fbb7d9dc-9dcd-4fdc-b7df-6c7c39b7703dMacOS: Desktop