Open trjExpensify opened 2 weeks ago
Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External
)
Current assignee @trjExpensify is eligible for the Bug assigner, not assigning anyone new.
When a new user selects the Manage my team's expenses onboarding intent:
- The next question we ask should be for their Business name
- Upon clicking the confirmation button on the business name page we should trigger the CreateWorkspace API command immediately
@trjExpensify Is this behaviour specific to "Manage my team's expenses" option or for all other options?
Yes, just that option. None of the other options ask for a business name. 👍
ohk, i asked becuase with current PR changes it was asking for bussiness name for all options
Yeah, I see the commit to not do that 😅
⚠️ Looks like this issue was linked to a Deploy Blocker here
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v1.4.70-1 Reproducible in staging?: Y Reproducible in production?: If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @trjExpensify Slack conversation: https://expensify.slack.com/archives/C036QM0SLJK/p1714746065450189?thread_ts=1714400621.865599&cid=C036QM0SLJK
Action Performed:
Manage my team's Expenses
in the onboarding modalExpected Result:
When a new user selects the
Manage my team's expenses
onboarding intent:Business name
CreateWorkspace
API command immediatelyActual Result:
We ask for business name last, so as a result, we trigger the
CreateWorkspace
command at the end of the onboarding flow.Workaround:
N/A
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
https://github.com/Expensify/App/assets/16232057/8e019b05-7013-45dc-bb49-49e8480ce6cb
View all open jobs on GitHub
CC: @anmurali @francoisl @NikkiWines @mountiny @danielrvidal
Issue Owner
Current Issue Owner: @thesahindia