Closed DylanDylann closed 2 weeks ago
@ishpaul777 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and not onIconClick
).myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components using Avatar
have been tested & I retested again)/** comment above it */
this
properly so there are no scoping issues (i.e. for onClick={this.submit}
the method this.submit
should be bound to this
in the constructor)this
are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this);
if this.submit
is never passed to a component event handler like onClick
)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG
)Avatar
is modified, I verified that Avatar
is working as expected in all cases)Design
label and/or tagged @Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test
steps.@ishpaul777 Uploaded all videos. All yours
Oh wait a minute, I need to update something
@ishpaul777 Explain for new commit: The business name is only visible if the user select the Manage Team option
:test_tube::test_tube: Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! :test_tube::test_tube: | Android :robot: | iOS :apple: |
---|---|---|
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/41593/index.html | https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/41593/index.html | |
Desktop :computer: | Web :spider_web: | |
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/41593/NewExpensify.dmg | https://41593.pr-testing.expensify.com | |
:eyes: View the workflow run that generated this build :eyes:
Agreed with @ishpaul777, testing the adhoc build of this PR the CreateWorkspace
command isn't fired at all:
https://github.com/Expensify/App/assets/16232057/d1d32d5b-8f2c-4417-b532-a4b55cc7cd14
We want CreateWorkspace
to be triggered when they hit confirm on the "Where do you work?" page.
Then we want the CompleteGuidedSetup
command to be triggered when they confirm on the "What's your name?" page.
@ishpaul777 Updated
@DylanDylann can you record a quick video with the network tab open in the console with these latest changes? Thanks!
Workspace is created at the right time for me (haven't reviewed the code in detail yet)
https://github.com/Expensify/App/assets/2229301/c4e8b713-6df1-4e57-a56e-e5f6e8e1a748
hey i just noticed we have to pass adminsChatReportID
to Report.completeOnboarding
in displayname page (where flow is completed)
@ishpaul777 What do you think about creating a new field called ONBOARDING_ADMINS_CHAT_REPORT_ID like we did with ONBOARDING_PURPOSE_SELECTED?
as long as we clear it after its usage, i think it should be fine, cc @francoisl
Yeah works for me 👍
@ishpaul777 @francoisl Updated
:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.
🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.71-6 🚀
platform | result |
---|---|
🤖 android 🤖 | success ✅ |
🖥 desktop 🖥 | success ✅ |
🍎 iOS 🍎 | success ✅ |
🕸 web 🕸 | success ✅ |
Details
Fixed Issues
$ https://github.com/Expensify/App/issues/41589 PROPOSAL: NA
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
https://github.com/Expensify/App/assets/141406735/c4209d73-75ba-4d3c-9ff1-7fa512ba2195Android: mWeb Chrome
https://github.com/Expensify/App/assets/141406735/85438a2e-9fff-4996-8490-97ac900964faiOS: Native
https://github.com/Expensify/App/assets/141406735/396fa5f5-30aa-479d-a0be-bc268199b792iOS: mWeb Safari
https://github.com/Expensify/App/assets/141406735/d6ba081b-8be5-4027-b26d-f168805e5464MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/141406735/860d3aef-0774-4d71-86de-c4f1a83437ecMacOS: Desktop
https://github.com/Expensify/App/assets/141406735/cf202935-b1fd-4a4a-8fb4-c398de572526