search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
2.99k stars 2.5k forks source link

Wallet - "Debit card setup not allowed" error appears when adding a card #41601

Closed lanitochka17 closed 1 week ago

lanitochka17 commented 2 weeks ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.70.0 Reproducible in staging?: Y Reproducible in production?: Unable to check If this was caught during regression testing, add the test name, ID and link from TestRail:https://expensify.testrail.io/index.php?/tests/view/4538717&group_by=cases:section_id&group_order=asc&group_id=229064 Issue reported by: Applause - Internal Team

Action Performed:

  1. Log in with an expensifail account
  2. Navigate to Profile - Wallet - Add bank account - Debit card
  3. Add "4000056655665556" as the Debit card number and fill the rest with random data
  4. Tap on the "Save" button
  5. Fill the fields with random data
  6. Tap on the "Save & continue" button

Expected Result:

I should be able to add a card without errors

Actual Result:

"Debit card setup not allowed" error appears when adding a card. The card is actually added and visible if you navigate back to the Wallet tab

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/63ff7f63-6aac-4273-b4d4-0cebbce61fc2

Bug6470083_1714743835478!IMG_2049

View all open jobs on GitHub

melvin-bot[bot] commented 2 weeks ago

Triggered auto assignment to @thienlnam (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

github-actions[bot] commented 2 weeks ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
lanitochka17 commented 2 weeks ago

@thienlnam FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

francoisl commented 2 weeks ago

This error is coming from the backend, and the code doesn't seem to have changed in a while. According to the code here we don't support setting up wallets with debit cards on purpose, so it's surprising that this test would have ever passed. It's not even a new test too, it was added in April 2023(?)

thienlnam commented 2 weeks ago

Sounds like this isn't a blocker then? We should actually change the error message here though

francoisl commented 2 weeks ago

I'm not sure... Maybe it is?

Reproducible in production?: Unable to check

Curious why, is this a new flow that was just added on a PR that's on staging now?

melvin-bot[bot] commented 1 week ago

@thienlnam Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

thienlnam commented 1 week ago

Asked about this here https://expensify.slack.com/archives/C9YU7BX5M/p1714763098629059

Turns out this was probably happening on prod but wasn't tested there since it would require a real debit card