Closed suneox closed 1 week ago
@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and not onIconClick
).myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components using Avatar
have been tested & I retested again)/** comment above it */
this
properly so there are no scoping issues (i.e. for onClick={this.submit}
the method this.submit
should be bound to this
in the constructor)this
are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this);
if this.submit
is never passed to a component event handler like onClick
)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG
)Avatar
is modified, I verified that Avatar
is working as expected in all cases)Design
label and/or tagged @Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test
steps.Adhoc build workflow is in progress.
:test_tube::test_tube: Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! :test_tube::test_tube: | Android :robot: | iOS :apple: |
---|---|---|
ā FAILED ā | https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/41603/index.html | |
The QR code can't be generated, because the android build failed | ||
Desktop :computer: | Web :spider_web: | |
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/41603/NewExpensify.dmg | https://41603.pr-testing.expensify.com | |
:eyes: View the workflow run that generated this build :eyes:
Trying again...
:test_tube::test_tube: Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! :test_tube::test_tube: | Android :robot: | iOS :apple: |
---|---|---|
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/41603/index.html | https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/41603/index.html | |
Desktop :computer: | Web :spider_web: | |
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/41603/NewExpensify.dmg | https://41603.pr-testing.expensify.com | |
:eyes: View the workflow run that generated this build :eyes:
It tests really well thanks! I don't think we need to wait for David. Merging š
https://github.com/Expensify/App/assets/26260477/3b058485-0ba4-41db-b048-2e09a5a39243
:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.
š Deployed to staging by https://github.com/neil-marcellini in version: 1.4.72-0 š
platform | result |
---|---|
š¤ android š¤ | success ā |
š„ desktop š„ | success ā |
š iOS š | success ā |
šø web šø | success ā |
š Deployed to production by https://github.com/Beamanator in version: 1.4.72-1 š
platform | result |
---|---|
š¤ android š¤ | success ā |
š„ desktop š„ | success ā |
š iOS š | success ā |
šø web šø | success ā |
Details
Fixed Issues
$ https://github.com/Expensify/App/issues/40211 PROPOSAL: https://github.com/Expensify/App/issues/40211#issuecomment-2059726565
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
https://github.com/Expensify/App/assets/11959869/39342eb2-38d4-4fef-9d29-b080843518d7Android: mWeb Chrome
https://github.com/Expensify/App/assets/11959869/d0825b96-de7f-4771-9228-fb8a11ed863ciOS: Native
https://github.com/Expensify/App/assets/11959869/731ee32b-519b-4f97-a73a-08774e46c87diOS: mWeb Safari
https://github.com/Expensify/App/assets/11959869/e59a469f-706b-417c-a637-65dbad5fd4beMacOS: Chrome / Safari
https://github.com/Expensify/App/assets/11959869/29baa701-9d43-495e-b85a-31bc6612f3b2MacOS: Desktop
https://github.com/Expensify/App/assets/11959869/20a06157-90fd-45c0-bb74-f0fbeefaccd2