search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
2.99k stars 2.5k forks source link

[$250] Workspace - RBR is aligned to top of WS bar #41609

Open kavimuru opened 2 weeks ago

kavimuru commented 2 weeks ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.70-1 Reproducible in staging?: y Reproducible in production?: n/a If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause internal team Slack conversation:

Action Performed:

Precondition: Sign up new account.

  1. Add workspace
  2. Go to Workspace > Workflows
  3. Enable 'Make or track payments'
  4. Add VBA (Regions bank)
  5. Go to Workspaces tab

Expected Result:

RBR is aligned to center of WS bar

Actual Result:

RBR is aligned to top of WS bar

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6469815_1714726545108!RBR

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01e565fa0b66eb131c
  • Upwork Job ID: 1787654855430000640
  • Last Price Increase: 2024-05-07
  • Automatic offers:
    • Krishna2323 | Contributor | 0
Issue OwnerCurrent Issue Owner: @thesahindia
melvin-bot[bot] commented 2 weeks ago

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

kavimuru commented 2 weeks ago

@isabelastisser FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

Krishna2323 commented 2 weeks ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace - RBR is aligned to top of WS bar

What is the root cause of that problem?

Styles applied to icon container and the main View of ThreeDotMenuOrPendingIcon is incorrect. https://github.com/Expensify/App/blob/387ab0edd9d2c01c2a0be72950490c94b1b7d9d9/src/pages/workspace/WorkspacesListRow.tsx#L145-L158

What changes do you think we should make in order to solve the problem?

The icon container should not have the styles.flex0 styles and the main View of ThreeDotMenuOrPendingIcon should have the styles.flexRow style applied to it.

Also we need to apply styles to icon container for alignment and spacing for narrow layouts. We can create a style object like we do with isNarrow && styles.workspaceListBadge. https://github.com/Expensify/App/blob/387ab0edd9d2c01c2a0be72950490c94b1b7d9d9/src/pages/workspace/WorkspacesListRow.tsx#L147

https://github.com/Expensify/App/blob/387ab0edd9d2c01c2a0be72950490c94b1b7d9d9/src/pages/workspace/WorkspacesListRow.tsx#L158

isNarrow && {flexDirection: 'column', justifyContent: 'flex-start', marginLeft: 16, marginTop: 10},

What alternative solutions did you explore? (Optional)

Result

https://github.com/Expensify/App/assets/85894871/d361b9ab-91ef-4da3-b788-b05bf1133af8

Krishna2323 commented 2 weeks ago

Proposal Updated

Krishna2323 commented 2 weeks ago

Proposal Updated

melvin-bot[bot] commented 1 week ago

Job added to Upwork: https://www.upwork.com/jobs/~01e565fa0b66eb131c

melvin-bot[bot] commented 1 week ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

melvin-bot[bot] commented 1 week ago

@isabelastisser Whoops! This issue is 2 days overdue. Let's get this updated quick!

Isaac017 commented 1 week ago

Here's a proposal for the Expensify project:

Title: Unifying Front-end with React Native Migration

Proposal:

I understand that Expensify is seeking to unify its front-end across platforms using React Native. The GitHub issue outlines the requirements for this migration. My proposal focuses on addressing the key challenges and providing a technical explanation of the changes I will make.

Objectives:

  1. Migrate the existing front-end to React Native, ensuring a seamless user experience across platforms.
  2. Implement a consistent design language and component library.
  3. Ensure compatibility with existing APIs and backend infrastructure.
  4. Conduct thorough testing on multiple platforms (iOS, Android, and Web).

Technical Approach:

  1. Set up a new React Native project, integrating it with the existing Expensify codebase.
  2. Develop a custom component library, utilizing React Native elements and Expensify's design guidelines.
  3. Implement platform-specific optimizations for performance and user experience.
  4. Utilize React Native's built-in navigation and routing features for a cohesive user flow.
  5. Conduct thorough testing, including unit tests, integration tests, and UI tests.

Deliverables:

  1. A detailed report outlining the migration process and technical decisions.
  2. A fork of the Expensify/App repository with the implemented changes.
  3. A pull request for merging the changes into the main codebase.
  4. Screenshots and confirmation of successful testing on all platforms.

Timeline:

  1. Initial setup and planning: 2 days
  2. Component library development: 5 days
  3. Platform-specific optimizations: 3 days
  4. Testing and debugging: 5 days
  5. Documentation and reporting: 2 days

Total estimated time: 17 days

Please review my proposal, and if accepted, I will post it on Upwork and begin working on the project. I will then submit the code for review and merge into the Expensify codebase.

melvin-bot[bot] commented 1 week ago

📣 @Isaac017! 📣 Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details. Screen Shot 2022-11-16 at 4 42 54 PM Format: 
    Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>
Isaac017 commented 1 week ago

Contributor details Your Expensify account email: isaacochagwu001@gmail.com Upwork Profile Link: <Contributor details Your Expensify account email: https://www.upwork.com/freelancers/~01ecb4ea889e2c3a93 Here's a proposal for the Expensify project:

Title: Unifying Front-end with React Native Migration

Proposal:

I understand that Expensify is seeking to unify its front-end across platforms using React Native. The GitHub issue outlines the requirements for this migration. My proposal focuses on addressing the key challenges and providing a technical explanation of the changes I will make.

Objectives:

  1. Migrate the existing front-end to React Native, ensuring a seamless user experience across platforms.
  2. Implement a consistent design language and component library.
  3. Ensure compatibility with existing APIs and backend infrastructure.
  4. Conduct thorough testing on multiple platforms (iOS, Android, and Web).

Technical Approach:

  1. Set up a new React Native project, integrating it with the existing Expensify codebase.
  2. Develop a custom component library, utilizing React Native elements and Expensify's design guidelines.
  3. Implement platform-specific optimizations for performance and user experience.
  4. Utilize React Native's built-in navigation and routing features for a cohesive user flow.
  5. Conduct thorough testing, including unit tests, integration tests, and UI tests.

Deliverables:

  1. A detailed report outlining the migration process and technical decisions.
  2. A fork of the Expensify/App repository with the implemented changes.
  3. A pull request for merging the changes into the main codebase.
  4. Screenshots and confirmation of successful testing on all platforms.

Timeline:

  1. Initial setup and planning: 2 days
  2. Component library development: 5 days
  3. Platform-specific optimizations: 3 days
  4. Testing and debugging: 5 days
  5. Documentation and reporting: 2 days

Total estimated time: 17 days

Please review my proposal, and if accepted, I will post it on Upwork and begin working on the project. I will then submit the code for review and merge into the Expensify codebase.

melvin-bot[bot] commented 1 week ago

⚠️ Missing/invalid email or upwork profile link. Please make sure you add both your Expensify email and Upwork profile link in the format specified.

Isaac017 commented 1 week ago

Contributor  isaacochagwu001@expensify.com

 https://www.upwork.com/freelancers/~01ecb4ea889e2c3a93 Here's a proposal for the Expensify project:

Title: Unifying Front-end with React Native Migration

Proposal:

I understand that Expensify is seeking to unify its front-end across platforms using React Native. The GitHub issue outlines the requirements for this migration. My proposal focuses on addressing the key challenges and providing a technical explanation of the changes I will make.

Objectives:

Migrate the existing front-end to React Native, ensuring a seamless user experience across platforms.

Implement a consistent design language and component library.

Ensure compatibility with existing APIs and backend infrastructure.

Conduct thorough testing on multiple platforms (iOS, Android, and Web).

Technical Approach:

Set up a new React Native project, integrating it with the existing Expensify codebase.

Develop a custom component library, utilizing React Native elements and Expensify's design guidelines.

Implement platform-specific optimizations for performance and user experience.

Utilize React Native's built-in navigation and routing features for a cohesive user flow.

Conduct thorough testing, including unit tests, integration tests, and UI tests.

Deliverables:

A detailed report outlining the migration process and technical decisions.

A fork of the Expensify/App repository with the implemented changes.

A pull request for merging the changes into the main codebase.

Screenshots and confirmation of successful testing on all platforms.

Timeline:

Initial setup and planning: 2 days

Component library development: 5 days

Platform-specific optimizations: 3 days

Testing and debugging: 5 days

Documentation and reporting: 2 days

Total estimated time: 17 days

Please review my proposal, and if accepted, I will post it on Upwork and begin working on the project. I will then submit the code for review and merge into the Expensify codebase.

isabelastisser commented 1 week ago

@thesahindia, can you please provide an update? Thanks!

thesahindia commented 1 week ago

@Krishna2323's proposal looks good to me!

🎀 👀 🎀 C+ reviewed

melvin-bot[bot] commented 1 week ago

Triggered auto assignment to @MonilBhavsar, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

isabelastisser commented 1 week ago

@MonilBhavsar, please review the proposals. Thanks!

MonilBhavsar commented 1 week ago

Looks good to me

melvin-bot[bot] commented 1 week ago

📣 @Krishna2323 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

Krishna2323 commented 1 week ago

@thesahindia, PR ready for review.