[$250] Get Assistance workflow from bank account page doesn't match other workflows

kavimuru commented 2 weeks ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.70-1 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause internal team Slack conversation:

Action Performed:

Go to https://staging.new.expensify.com/
Tap profile --- workspaces --- create a new workspace
Tap Profile > Tap more features
Enable Workflows
Tap Workflows -- tap connect bank account
Tap help question mark on top left
On the Get Assistance page, tap "chat with concierge" and tap device back button
Notice user is directed to workflow page
Tap explore help docs and tap device back button
Notice User correctly navigated back to "get assistance page"

Expected Result:

Expected Result: When tapping Back should navigate to Get assistance page for all the scenarios

Tapping "Chat with Concierge" and pressing Back button redirects to "workflow page"
Tapping "Schedule a setup call" and pressing Back button redirects to Get assistance page
Tapping "Explore help docs" and pressing Back button redirects to Get assistance page

Actual Result:

From "chat with concierge" page when navigates back directed to Workflows page instead of Get assistance page.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/43996225/0733fe50-9436-44c9-a0dd-8b4804786377

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0195f7d860bd49c0ee
Upwork Job ID: 1789908451827134464
Last Price Increase: 2024-05-13

Issue Owner

Current Issue Owner: @Christinadobrzyn

melvin-bot[bot] commented 2 weeks ago

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

kavimuru commented 2 weeks ago

@twisterdotcom FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

twisterdotcom commented 2 weeks ago

This was assigned after I finished work on Friday. I will be OOO all next week.

melvin-bot[bot] commented 2 weeks ago

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

nkdengineer commented 1 week ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

From "chat with concierge" page when navigates back directed to Workflows page instead of Get assistance page.

What is the root cause of that problem?

In here: https://github.com/Expensify/App/blob/8383d80013cf61e83fc8bd90eef5f8357f69cf91/src/pages/GetAssistancePage.tsx#L40 we use shouldDismissModal: true when navigating to concierge chat, leads to the Get assistance page is dissmissed, so when going back from concierge page, it redirects to Workflows page
What changes do you think we should make in order to solve the problem?
We can call Report.navigateToConciergeChat(true) in case of desktop device (!DeviceCapabilities.canUseTouchScreen(): true). Otherwise, using Report.navigateToConciergeChat()

What alternative solutions did you explore? (Optional)

NA

melvin-bot[bot] commented 1 week ago

@Christinadobrzyn Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Christinadobrzyn commented 1 week ago

I think this might be part of guided setup - adding to wave-collect.

Christinadobrzyn commented 1 week ago

Sorry - I'm still trying to test this.. I think we want to update the "Get Assistance" page off the Bank setup

To match this "Get Assistance" page - but I can't figure out where this page exists... testing

Christinadobrzyn commented 1 week ago

Asking QA for a buddy check on the expected behaviour - https://expensify.slack.com/archives/C9YU7BX5M/p1715151549856419

kavimuru commented 1 week ago

The issue is about navigating back after clicking different options in Get assistance page.

Tapping "Chat with Concierge" and pressing Back button redirects to "workflow page"
Tapping "Schedule a setup call" and pressing Back button redirects to Get assistance page
Tapping "Explore help docs" and pressing Back button redirects to Get assistance page

Expected Result: When tapping Back should navigate to Get assistance page for all the scenarios

Christinadobrzyn commented 1 week ago

Discussing with QA - https://expensify.slack.com/archives/C9YU7BX5M/p1715241694798869?thread_ts=1715151549.856419&cid=C9YU7BX5M

MelvinBot commented 1 week ago

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

kavimuru commented 1 week ago

Video added and OP updated. Hope it will help.

https://github.com/Expensify/App/assets/43996225/2ab877e5-9572-488f-a9f4-3d3f447c015e

Christinadobrzyn commented 1 week ago

Ah yes, that is helpful, I'll rewrite the OP steps based on this narrowed scope of the Android app.

melvin-bot[bot] commented 5 days ago

Job added to Upwork: https://www.upwork.com/jobs/~0195f7d860bd49c0ee

melvin-bot[bot] commented 5 days ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eh2077 (External)

Christinadobrzyn commented 5 days ago

updated the OP I think this can be external - I think this is part of Wave Collect Guided Setup

Christinadobrzyn commented 4 days ago

@eh2077 can you check out the proposal? https://github.com/Expensify/App/issues/41610#issuecomment-2095541277 TY!

eh2077 commented 4 days ago

Sure, reviewing proposal!

eh2077 commented 3 days ago

@nkdengineer 's proposal looks good to me. I think it makes senses to only dismiss modal when it's wide screen.

🎀👀🎀 C+ reviewed

melvin-bot[bot] commented 3 days ago

Triggered auto assignment to @roryabraham, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

melvin-bot[bot] commented 1 day ago

@roryabraham @Christinadobrzyn @eh2077 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

eh2077 commented 23 hours ago

Not overdue, waiting for @roryabraham 's review on https://github.com/Expensify/App/issues/41610#issuecomment-2113069509

Expensify / App