Closed cretadn22 closed 1 week ago
@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and not onIconClick
).myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components using Avatar
have been tested & I retested again)/** comment above it */
this
properly so there are no scoping issues (i.e. for onClick={this.submit}
the method this.submit
should be bound to this
in the constructor)this
are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this);
if this.submit
is never passed to a component event handler like onClick
)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG
)Avatar
is modified, I verified that Avatar
is working as expected in all cases)Design
label and/or tagged @Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test
steps.@cretadn22 Please run prettier to fix the lint error and upload videos
@DylanDylann Thanks for letting me know. I encountered some issues while running prettier, but I plan to address them soon
@DylanDylann It's fine now
@cretadn22 Should we update the same fix to the HeadeView, I see that in some cases we still display ReportScreen as RHP with HeaderView
@luacmartins @DylanDylann We can't use a ternary because of the lint rule
The code change is ready now
@luacmartins Bug: Flicker when navigating to transaction report (navigate again to search page a moment before going to transaction report)
https://github.com/Expensify/App/assets/141406735/b0288468-39a7-43d1-96f4-996345e1d60c
:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.
🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.71-6 🚀
platform | result |
---|---|
🤖 android 🤖 | success ✅ |
🖥 desktop 🖥 | success ✅ |
🍎 iOS 🍎 | success ✅ |
🕸 web 🕸 | success ✅ |
$ https://github.com/Expensify/App/issues/41579 PROPOSAL: https://github.com/Expensify/App/issues/41579#issuecomment-2093365530
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
https://github.com/Expensify/App/assets/168617111/cb5aacb6-71f3-494a-af88-ec08102cca30iOS: Native
https://github.com/Expensify/App/assets/168617111/c8362191-298a-4d4b-be6a-e8b5c4d38ba5iOS: mWeb Safari
https://github.com/Expensify/App/assets/168617111/c3444643-fcf8-4287-8ed1-04ed20b64e72MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/168617111/dd5bcec8-0abc-443b-bde9-5d90a4e93ef0MacOS: Desktop
https://github.com/Expensify/App/assets/168617111/1f4183e9-12b1-4cfc-a2eb-76b01b19e96d