Open m-natarajan opened 2 weeks ago
Triggered auto assignment to @adelekennedy (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
Payer is wrong in the header
When an employee creates a money request, the backend returns a request report where the managerID is the ID of the approver
Given that managerDisplayName
is "you"
If I understand correctly:
If this understanding is accurate, then the current logic here is wrong
We need to extract the approverID from the policy using approverID = policy.submitsTo
. Then
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
@adelekennedy Whoops! This issue is 2 days overdue. Let's get this updated quick!
Job added to Upwork: https://www.upwork.com/jobs/~01e9b6cf8e506af2ea
Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (External
)
@dukenv0307 just one proposal to review so far
"Waiting for you to pay these expenses" is displayed for approver who is not configured to pay the report
The logic we have here is wrong, in this case there's no further action required from the approver so the message shown is incorrect
Since there's no further action required from the approver in this case, we can update this to the No further action required!
next step like in here, this is also consistent with what the back-end returns.
Or we can use the no action required message for the whole block here (except the case where the current user is the payer of the request too)
Early return No further action required!
next step in here if the current user cannot pay the request (eg. Is not one of the workspace admins, the full condition for checking if user can pay the request is here and !ReportUtils.isInvoiceReport
here)
starting review now
I like @dominictb's alternative solution
πππ C+ reviewed
Triggered auto assignment to @flodnv, see https://stackoverflow.com/c/expensify/questions/7972 for more details.
@mountiny fancy giving this proposal a review?
π£ @dukenv0307 π An offer has been automatically sent to your Upwork account for the Reviewer role π Thanks for contributing to the Expensify app!
π£ @dominictb You have been assigned to this job! Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review π§βπ» Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs! Keep in mind: Code of Conduct | Contributing π
Happy to take this over from Flo as I have worked on the next steps before.
@dominictb Your alternative solution looks better. When the isOwner
condition was implemented, we still did not have the policy reimburser data in the App or policy settings. Now, we should use the method you have mentioned in the alternative solutions or the isPayer logic, needs to be checked thoroughly. This should ensure the payer will get this message correctly.
If you havenβt already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.70-1 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @JmillsExpensify Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1714518611299619
Action Performed:
Prerequisite: Have a collect workspace with admin, approver, and employee.
Expected Result:
"Waiting for you to pay these expenses" should not be displayed for the approver
Actual Result:
"Waiting for you to pay these expenses" is displayed for approver who is not configured to pay the report
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/38435837/f10ac540-36d7-4afa-990d-7ae177a84e52
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @dukenv0307