Closed dangrous closed 3 days ago
@jasperhuangg Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
Think we need to HOLD this on the deploy of the Auth PR in order for QA to pass
Ah yeah, fair - I'll put that in the title and follow
oh you already did whoops haha
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and not onIconClick
).myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components using Avatar
have been tested & I retested again)/** comment above it */
this
properly so there are no scoping issues (i.e. for onClick={this.submit}
the method this.submit
should be bound to this
in the constructor)this
are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this);
if this.submit
is never passed to a component event handler like onClick
)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG
)Avatar
is modified, I verified that Avatar
is working as expected in all cases)Design
label and/or tagged @Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test
steps.Auth PR is on prod, taking the hold off.
:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.
Details
Need to fix on the backend as well, also need to make sure this doesn't allow flagging on anything it shouldn't
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/389347 PROPOSAL: N/A
Tests
Same as QA - you'll need to check out https://github.com/Expensify/Auth/pull/10829 if it's not yet merged for local testing
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
![android](https://github.com/Expensify/App/assets/5487802/022185c7-1e70-4e69-8217-96dd72275536)Android: mWeb Chrome
![android_chrome](https://github.com/Expensify/App/assets/5487802/a78a2142-c151-4ad1-bee2-37201e20191f)iOS: Native
My dev is not cooperating at all, this one will not load for me. It should work though given that the change is not platform or visual specificiOS: mWeb Safari
![ios_safari](https://github.com/Expensify/App/assets/5487802/1809bd6f-8f7d-4a34-a2ab-a70bd25437d8)MacOS: Chrome / Safari
MacOS: Desktop