Use new multi config edit command

aldo-expensify commented 2 weeks ago

Details

Sometimes changing a connections configuration translate in multiple keys being edited. Currently, the existing command UpdatePolicyConnectionConfig only supports updating one key at a time, which eventually produced work arounds that break 1:1:1.

This PR is adding a new UpdateManyPolicyConnectionConfigurations command that takes a partial connection config object to edit multiple settings in one call. An example of this is:

If you change the Out-of-pocket account type from CHECK to BILL, then you also need to update the selected account.

Needs:

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/390731 PROPOSAL:

Tests

Have a workspace with QBO connected.
Go to "Export > Export out-of-pocket-expenses as"
Change the "Export as" value between the 3 options
Verify that the selected account updates choosing the first available from the new valid values
Change the setting "Export company cards as" to "Credit Card"
Verify that the account selected changed to a valid account
Change the setting "Export company cards as" to "Vendor Bill"
Verify that setting "Default vendor" appeared
Verify that when "Default vendor" is toggled, you see the setting "Vendor"
Verify that when "Default vendor" is toggled, "Vendor" gets the first value selected by default

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR
- [x] I added steps for local testing in the Tests section
- [x] I added steps for the expected offline behavior in the Offline steps section
- [x] I added steps for Staging and/or Production testing in the QA steps section
- [x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- [x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- [x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:
- [x] Android: Native
- [x] Android: mWeb Chrome
- [x] iOS: Native
- [x] iOS: mWeb Safari
- [x] MacOS: Chrome / Safari
- [x] MacOS: Desktop
[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)
- [x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- [x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- [x] I verified that comments were added to code that is not self explanatory
- [x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- [x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - [x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- [x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- [x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- [x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- [x] I verified the JSDocs style guidelines (in STYLE.md) were followed
[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:
- [x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
[x] If a new CSS style is added I verified that:
- [x] A similar style doesn't already exist
- [x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- [x] I verified that all the inputs inside a form are aligned with each other.
- [x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/87341702/d3fa227c-7990-4360-be84-7f9dd56ddbc2

MacOS: Desktop

hayata-suenaga commented 1 week ago

Just a heads-up, there is a PR to update screens related to the company card export options. If that PR is merged first, there might be quite a lot of merge conflicts on these pages 🙇

melvin-bot[bot] commented 4 days ago

@ishpaul777 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

aldo-expensify commented 4 days ago

@trjExpensify @hayata-suenaga this is ready for review again. For details about translations, lets address them in a separate follow up. I don't want this running into conflicts and hold on unrelated already existing bugs.

trjExpensify commented 4 days ago

@trjExpensify @hayata-suenaga this is ready for review again. For details about translations, lets address them in a separate follow up. I don't want this running into conflicts and hold on unrelated already existing bugs.

Nice! Time for an adhoc build?

github-actions[bot] commented 4 days ago

:test_tube::test_tube: Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! :test_tube::test_tube:	Android :robot:	iOS :apple:
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/41627/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/41627/index.html

Desktop :computer:	Web :spider_web:
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/41627/NewExpensify.dmg	https://41627.pr-testing.expensify.com

:eyes: View the workflow run that generated this build :eyes:

github-actions[bot] commented 4 days ago

:test_tube::test_tube: Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! :test_tube::test_tube:	Android :robot:	iOS :apple:
❌ FAILED ❌	❌ FAILED ❌
The QR code can't be generated, because the android build failed	The QR code can't be generated, because the iOS build failed
Desktop :computer:	Web :spider_web:
❌ FAILED ❌	❌ FAILED ❌
The QR code can't be generated, because the Desktop build failed	The QR code can't be generated, because the web build failed

:eyes: View the workflow run that generated this build :eyes:

trjExpensify commented 3 days ago

Gave this a test, posted here.

aldo-expensify commented 3 days ago

@hayata-suenaga what this PR https://github.com/Expensify/App/pull/42102 fixed was already being fixed here, now we have conflicts. Please prioritize reviewing this doesn't keep running into conflicts 🙏

aldo-expensify commented 3 days ago

lol conflicts again

ishpaul777 commented 3 days ago

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR
- [x] I verified the steps for local testing are in the Tests section
- [x] I verified the steps for Staging and/or Production testing are in the QA steps section
- [x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- [x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:
- [x] Android: Native
- [x] Android: mWeb Chrome
- [x] iOS: Native
- [x] iOS: mWeb Safari
- [x] MacOS: Chrome / Safari
- [x] MacOS: Desktop
[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)
- [x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- [x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- [x] I verified that comments were added to code that is not self explanatory
- [x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- [x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- [x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- [x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- [x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- [x] I verified the JSDocs style guidelines (in STYLE.md) were followed
[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:
- [x] A similar component doesn't exist in the codebase
- [x] All props are defined accurately and each prop has a /** comment above it */
- [x] The file is named correctly
- [x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- [x] The only data being stored in the state is data necessary for rendering and nothing else
- [x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- [x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- [x] All JSX used for rendering exists in the render method
- [x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
[x] If any new file was added I verified that:
- [x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
[x] If a new CSS style is added I verified that:
- [x] A similar style doesn't already exist
- [x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- [x] I verified that all the inputs inside a form are aligned with each other.
- [x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

hayata-suenaga commented 3 days ago

@ishpaul777, once you're done with the checklist, please DM me on Slack 😄 so that I can merge

ishpaul777 commented 3 days ago

Okay 😄

ishpaul777 commented 3 days ago

Just linked QB account, but i am not able to set Export out-of-pocket-expenses from the option,

https://github.com/Expensify/App/assets/104348397/38d0b32e-2390-4190-8484-0028ff64e97b

hayata-suenaga commented 3 days ago

@ishpaul777, is it working for company card export configuration screens?

aldo-expensify commented 3 days ago

Just linked QB account, but i am not able to set Export out-of-pocket-expenses from the option,

hmm, I wonder if you may have missed onyx updates because of the servers having problems.... Do you have an account that is currently connected to QBO? it shouldn't be necessary to connect a new account

ishpaul777 commented 3 days ago

Nope : (

https://github.com/Expensify/App/assets/104348397/da547de2-02bf-4ea7-90e0-a2d8521f8b83

aldo-expensify commented 3 days ago

Also, from video, it looks like the requests are going through very slowly.

ishpaul777 commented 3 days ago

Do you have an account that is currently connected to QBO? it shouldn't be necessary to connect a new account

Sadly. first time working on this feature so i dont have one yet.

ishpaul777 commented 3 days ago

I wonder if you may have missed onyx updates because of the servers having problems....

yes it appears to be the RC.

ishpaul777 commented 3 days ago

is there any steps to get the "Accounts Payable"/ "Vendors" List @aldo-expensify

hayata-suenaga commented 3 days ago

is there any steps to get the "Accounts Payable"/ "Vendors" List @aldo-expensify

@ishpaul777, do you have Location import and tax import enabled at the same time?

hayata-suenaga commented 3 days ago

if that happens (although very unlikely), there won't be any available option on the list of account options

ishpaul777 commented 3 days ago

no Location import is disabled is disabled, where's tax import 🤔

ishpaul777 commented 3 days ago

is there any config i need to do in QBO account i just completed the onboarding for QBO

ishpaul777 commented 3 days ago

Code wise looks good to me!, just need to do thorough testing and complete videos, will check back again tomorrow in my morning

aldo-expensify commented 3 days ago

is there any steps to get the "Accounts Payable"/ "Vendors" List @aldo-expensify

I get them without doing any extra action, but maybe it depends on the QBO account used for testing? I used qa@expensify.com

aldo-expensify commented 3 days ago

is there any config i need to do in QBO account i just completed the onboarding for QBO

Sorry, I really have no idea of how to setup this account properly... I just use one that was already there.

aldo-expensify commented 3 days ago

Code wise looks good to me!, just need to do thorough testing and complete videos, will check back again tomorrow in my morning

I would prefer ideally to not have to wait until tomorrow for testing this. @hayata-suenaga can you test this in web and then we merge?

hayata-suenaga commented 2 days ago

testing now...

hayata-suenaga commented 2 days ago

Tested well 🎉

https://github.com/Expensify/App/assets/98560306/b83c3dc0-a782-47b8-acec-7e9b441eea7b

hayata-suenaga commented 2 days ago

checked off the remaining items on the checklist

OSBotify commented 2 days ago

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

aldo-expensify commented 2 days ago

Thank you @hayata-suenaga for the quick work 🙇

Expensify / App