Open tienifr opened 2 weeks ago
🤣 Came to see this PR since it was linked with the web-e changes https://github.com/Expensify/Web-Expensify/pull/41946 and, by mistake, approved it instead of web-e PR. Please ignore it.
@rojiphil Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
I encountered a problem when building native apps. Will update videos in native ASAP
@rojiphil Please help review once you have a chance. Thanks
@rojiphil Please help review once you have a chance. Thanks
@tienifr I have planned for this today. I will review and share an update.
@rojiphil I resolved all your comments
Details
Fixed Issues
$ https://github.com/Expensify/App/issues/40664 PROPOSAL: https://github.com/Expensify/App/issues/40664#issuecomment-2068331254
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
https://github.com/Expensify/App/assets/113963320/dc9d8ba0-a3a9-4f29-ae59-666fe5763379iOS: Native
iOS: mWeb Safari
https://github.com/Expensify/App/assets/113963320/df959dbf-adca-48c0-b349-8efa3e1a291dMacOS: Chrome / Safari
https://github.com/Expensify/App/assets/113963320/32dde034-d4d1-4d52-bb02-629e9b27c959MacOS: Desktop
https://github.com/Expensify/App/assets/113963320/6dcbc285-424c-424e-a07a-a2bf25c757e1