Open Krishna2323 opened 2 weeks ago
@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
@JmillsExpensify, I made changes to hide the add receipt placeholder when the IOU is approved or settled. I believe this is the expected behavior, am I correct?
@JmillsExpensify, I made changes to hide the add receipt placeholder when the IOU is approved or settled. I believe this is the expected behavior, am I correct?
Yes, that's correct. Thanks for confirming!
@Krishna2323 We are showing 'Review Required' in those reports which are not in paid policy (for example: one-to-one chat). I belive we should not show it.
https://github.com/Expensify/App/assets/25876548/78b17001-a4ee-44a0-8557-e6206394de06
Sorry for delay, will be updating this today or tomorrow for sure.
@Krishna2323 We are showing 'Review Required' in those reports which are not in paid policy (for example: one-to-one chat). I belive we should not show it.
@sobitneupane, updated.
Details
Fixed Issues
$ https://github.com/Expensify/App/issues/41489 PROPOSAL: https://github.com/Expensify/App/issues/41489#issuecomment-2091075371
Tests
Add receipt placeholder
is not shownAdd receipt placeholder
is not shownOffline tests
Add receipt placeholder
is not shownAdd receipt placeholder
is not shownQA Steps
Add receipt placeholder
is not shownAdd receipt placeholder
is not shownPR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
https://github.com/Expensify/App/assets/85894871/ea6b8f43-eaca-4868-877e-0ec706ab30f3Android: mWeb Chrome
https://github.com/Expensify/App/assets/85894871/92d12840-8ff4-4264-9f53-655b8ef4f033iOS: Native
https://github.com/Expensify/App/assets/85894871/ea653103-ff13-4b2f-9e87-5f22769c4203iOS: mWeb Safari
https://github.com/Expensify/App/assets/85894871/8a4f6cb9-f164-4936-9cf2-b41fb96cce0bMacOS: Chrome / Safari
https://github.com/Expensify/App/assets/85894871/2a57ce80-8299-4bc7-b971-89e91fb0f5b0MacOS: Desktop
https://github.com/Expensify/App/assets/85894871/bdb61057-c927-4a05-a54e-87e1c8cb868e