Closed tienifr closed 4 days ago
@c3024 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and not onIconClick
).myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components using Avatar
have been tested & I retested again)/** comment above it */
this
properly so there are no scoping issues (i.e. for onClick={this.submit}
the method this.submit
should be bound to this
in the constructor)this
are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this);
if this.submit
is never passed to a component event handler like onClick
)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG
)Avatar
is modified, I verified that Avatar
is working as expected in all cases)Design
label and/or tagged @Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test
steps.:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.
π Deployed to staging by https://github.com/aldo-expensify in version: 1.4.74-0 π
platform | result |
---|---|
π€ android π€ | success β |
π₯ desktop π₯ | success β |
π iOS π | success β |
πΈ web πΈ | success β |
Looks like this had some side effects in other lists - https://github.com/Expensify/App/issues/42189#issuecomment-2113410903 - let me know what you think!
Details
Deleted workspace room display in task's share somewhere list. This PR fixes that.
Fixed Issues
$ https://github.com/Expensify/App/issues/41062 PROPOSAL: https://github.com/Expensify/App/issues/41062#issuecomment-2079040625
Tests
#admins
room does not showOffline tests
NA
QA Steps
#admins
room does not showPR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
https://github.com/Expensify/App/assets/113963320/13f0b8ef-4128-49eb-95d0-06adbf0a995eAndroid: mWeb Chrome
https://github.com/Expensify/App/assets/113963320/47a66582-f407-49ca-a8ad-6e82760b0088iOS: Native
https://github.com/Expensify/App/assets/113963320/dea54b0d-2189-44db-a338-e261d25b5484iOS: mWeb Safari
https://github.com/Expensify/App/assets/113963320/1dff1acb-91c4-4cc6-8882-17756cb8f41fMacOS: Chrome / Safari
https://github.com/Expensify/App/assets/113963320/671c50c0-a9b9-4ac1-956a-1ad8838ee99eMacOS: Desktop
https://github.com/Expensify/App/assets/113963320/80b61a24-ec91-4591-ac64-03c7238855bf