Closed Nodebrute closed 2 weeks ago
@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
@Nodebrute Are you having trouble adding Screenshots/Videos for iOS: Native / iOS: mWeb Safari ?
[!note] It's important to go through the flow on all platforms to verify that the issue is fixed, no matter how small / big the code changes are.
@ikevin127 Apologies, my iOS build is currently failing. I'll add the iOS screenshots shortly.
@ikevin127 I have added videos for iOS: Native / iOS: mWeb Safari.
@Nodebrute Thanks for adding the vids!
@chiragsalian PR is ready for final review!
Merge freeze is done, lets goo.
:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.
š Deployed to staging by https://github.com/chiragsalian in version: 1.4.73-0 š
platform | result |
---|---|
š¤ android š¤ | success ā |
š„ desktop š„ | success ā |
š iOS š | success ā |
šø web šø | success ā |
š Deployed to production by https://github.com/Beamanator in version: 1.4.73-7 š
platform | result |
---|---|
š¤ android š¤ | success ā |
š„ desktop š„ | success ā |
š iOS š | success ā |
šø web šø | success ā |
Details
Fixed Issues
$ https://github.com/Expensify/App/issues/41325 PROPOSAL: https://github.com/Expensify/App/issues/41325#issuecomment-2085993852
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
https://github.com/Expensify/App/assets/93134676/d08d5591-f244-4ee8-8efb-23b7e73ec06dAndroid: mWeb Chrome
https://github.com/Expensify/App/assets/93134676/61335865-7025-4503-9e2a-1600ed2625a5iOS: Native
https://github.com/Expensify/App/assets/93134676/51e49392-eb4c-4d88-bdb2-db2870d82031iOS: mWeb Safari
https://github.com/Expensify/App/assets/93134676/4b2040cd-cdad-4e1a-b952-43b7efb2d7c9MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/93134676/fad8a24d-b9bb-41e0-ba97-5fa4e2a00f34MacOS: Desktop
https://github.com/Expensify/App/assets/93134676/8123eee0-f1bc-49db-a63c-656de813a96d