Open hayata-suenaga opened 2 weeks ago
@rojiphil Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
@rojiphil bump on this one, please 🙇
I decided to go with the original UI copy here
Do you mean this one we settled on?
Updated the UI copy. Requesting the translation
still waiting for the translation. meanwhile, I solved the merge conflicts.
Details
Fixed Issues
$ https://github.com/Expensify/App/issues/41621 PROPOSAL: N/A
Tests / QA Steps
Create a new workspace
Go to the More Feature page and enable the accounting feature
Connect to QBO
Go to the Export page. Check that
Vendor Bill
is selected forExport out-of-pocket expenses as
by defaultGo to the Import page. Check the Location configuration. Check that the Switch is toggled off and locked. There should be a hint text under the Switch button. Use the screenshot below as a reference.
Go to the Export page. Select
Journal Entry
forExport out-of-pocket expenses as
Go to the Import page. Check Location. Confirm that now you can toggle the switch on or off (i.e. not locked)
Enable the Location import (i.e. toggle it on)
Export ->
Export out-of-pocket expenses as
Confirm that Journal Entry is the only option displayed.
Offline tests
N/A
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/98560306/12f2d5b8-99dc-44dc-b9c4-5207104c0aa5MacOS: Desktop