Closed bernhardoj closed 1 week ago
@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and not onIconClick
).myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components using Avatar
have been tested & I retested again)/** comment above it */
this
properly so there are no scoping issues (i.e. for onClick={this.submit}
the method this.submit
should be bound to this
in the constructor)this
are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this);
if this.submit
is never passed to a component event handler like onClick
)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG
)Avatar
is modified, I verified that Avatar
is working as expected in all cases)Design
label and/or tagged @Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test
steps.code looks good and tests well
:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.
🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.71-6 🚀
platform | result |
---|---|
🤖 android 🤖 | success ✅ |
🖥 desktop 🖥 | success ✅ |
🍎 iOS 🍎 | success ✅ |
🕸 web 🕸 | success ✅ |
Details
Currently, the transaction thread header only navigate to the profile page. This PR enable the navigation to the detail page.
Fixed Issues
$ https://github.com/Expensify/App/issues/41196 PROPOSAL: https://github.com/Expensify/App/issues/41196#issuecomment-2082396569
Tests
Same as QA Steps
Offline tests
Same as QA Steps
QA Steps
Prerequisite: submit more than 1 expense to any chat
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
https://github.com/Expensify/App/assets/50919443/a47d6190-b227-45ad-b395-07ab0c25a4e1Android: mWeb Chrome
https://github.com/Expensify/App/assets/50919443/45222529-69dd-4aec-a068-f1a215bcf2faiOS: Native
https://github.com/Expensify/App/assets/50919443/897bd8b0-bd54-4478-8666-6efb79082ee7iOS: mWeb Safari
https://github.com/Expensify/App/assets/50919443/86dcb07b-c469-437b-8338-c969454d451bMacOS: Chrome / Safari
https://github.com/Expensify/App/assets/50919443/290bfe44-b223-4bbc-838f-38fe6b4ff653MacOS: Desktop
https://github.com/Expensify/App/assets/50919443/98ac69ed-b0a6-434a-8923-a1344fd2df3d