Closed dragnoir closed 1 week ago
@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
Screenshots look good to me!
:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.
π Deployed to production by https://github.com/marcaaron in version: 1.4.71-6 π
platform | result |
---|---|
π€ android π€ | success β |
π₯ desktop π₯ | success β |
π iOS π | success β |
πΈ web πΈ | success β |
Details
This PR fixes the issue of top and bottom spacing on header status.
Fixed Issues
$ https://github.com/Expensify/App/issues/41424 PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
![image](https://github.com/Expensify/App/assets/12425932/a82d358c-3909-4f0a-9b11-27b4d93c4318)Android: mWeb Chrome
NAiOS: Native
![image](https://github.com/Expensify/App/assets/12425932/b967af6c-b72b-4ba7-94f8-8719d83182f9)iOS: mWeb Safari
NAMacOS: Chrome / Safari
NAMacOS: Desktop
NA