search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
2.99k stars 2.5k forks source link

[$250] Pay someone flow doesn’t include a reportAction to distinguish the payment method used (Expensify or elsewhere) #41645

Open m-natarajan opened 2 weeks ago

m-natarajan commented 2 weeks ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.70-2 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @trjExpensify Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1714729020479179

Action Performed:

Prerequisite: Pay someone with either Expensify or elsewhere option

  1. Login as a user who got paid
  2. Open the DM and observe the preview for money received
  3. Click to open the payment details and observe

    Expected Result:

    Method of payment displayed in both DM and details page (Expensify or elsewhere)

    Actual Result:

    Only xyz paid displayed and method of payment not displayed

    Workaround:

    Unknown

    Platforms:

    Which of our officially supported platforms is this issue occurring on?

    • [ ] Android: Native
    • [ ] Android: mWeb Chrome
    • [ ] iOS: Native
    • [ ] iOS: mWeb Safari
    • [X] MacOS: Chrome / Safari
    • [ ] MacOS: Desktop

Screenshots/Videos

image (1) Snip - (2) New Expensify

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~014f39f2dacd55f2a4
  • Upwork Job ID: 1787959016608243712
  • Last Price Increase: 2024-05-14
Issue OwnerCurrent Issue Owner: @ahmedGaber93
melvin-bot[bot] commented 2 weeks ago

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

jainilparikh commented 1 week ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

Payment type is not mentioned in the details page.

What is the root cause of that problem?

We do not have a field for payment type. We only have fields for 'amount', 'comment', 'merchant', 'date', 'category' and 'tag'.

What changes do you think we should make in order to solve the problem?

Add a new field similar to the one below for 'PaymentType' info: https://github.com/Expensify/App/blob/951c7b38e0ec83a876c5e1d24af81e9e6543fc5d/src/components/ReportActionItem/MoneyRequestView.tsx#L373-L386

PaymentType info is available in ParentReportAction array that's passed to this component. https://github.com/Expensify/App/blob/951c7b38e0ec83a876c5e1d24af81e9e6543fc5d/src/components/ReportActionItem/MoneyRequestView.tsx#L90

What alternative solutions did you explore? (Optional)

melvin-bot[bot] commented 1 week ago

@sakluger Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot[bot] commented 1 week ago

Job added to Upwork: https://www.upwork.com/jobs/~014f39f2dacd55f2a4

melvin-bot[bot] commented 1 week ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ahmedGaber93 (External)

ahmedGaber93 commented 1 week ago

@jainilparikh Thanks for the proposal.

I don't think we need to add a new field for payment type, we need to edit the header and IOU preview to be xyz paid $50.00 using Expensify instead of xyz paid $50.00

Screenshot 2024-05-09 at 3 52 39 PM Screenshot 2024-05-09 at 3 52 22 PM

jainilparikh commented 6 days ago

@ahmedGaber93 , the reportAction does not have any information about how payment is done (Via Expensify or via Elsewhere). This is what we get:


avatarUrl: undefined
chatReportID: "8115357106458061"
chatType: ""
currency: "INR"
description: ""
errorFields: []
fieldList:  undefined
invoiceReceiver:  undefined
iouReportID: undefined
isDeletedParentAction: undefined
isOptimisticReport: undefined
isOwnPolicyExpenseChat: false
isPinned: false
isPolicyExpenseChat: undefined
isWaitingOnBankAccount: false
lastMentionedTime: undefined
lastReadTime: "2024-05-12 05:03:17.881"
lastVisibleActionCreated: "2024-05-12 05:03:17.881"
managerID: 16778387
nonReimbursableTotal: 0
notificationPreference: "always"
oldPolicyName: ""
ownerAccountID: 17102600
parentReportActionID: "189825184571791248"
parentReportID: "8115357106458061"
participantAccountIDs: (2) [16778387, 17102600]
pendingFields: undefined
permissions: (2) ['read', 'write']
policyID: "E1269E8555168358"
policyName: undefined
reportID: "7799079344254003"
reportName: "IOU"
stateNum: 2

Do we first need the BE to send this info in the parentReportActions ?

sakluger commented 5 days ago

Not overdue, we're still discussing the expected behavior.

melvin-bot[bot] commented 4 days ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot[bot] commented 4 days ago

@sakluger, @ahmedGaber93 Huh... This is 4 days overdue. Who can take care of this?

ahmedGaber93 commented 4 days ago

I checked it today, we already have the paymentType in FE but not with this reportAction, I will complete checking tomorrow to know if we can catch it from FE, or it requires BE changes

melvin-bot[bot] commented 2 days ago

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] commented 2 days ago

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

sakluger commented 2 days ago

Reassigning while I'm OOO for two weeks.

melvin-bot[bot] commented 2 days ago

Current assignee @sakluger is eligible for the Bug assigner, not assigning anyone new.

sakluger commented 2 days ago

Al will also be OOO for the same time, re-reassigning!

melvin-bot[bot] commented 2 days ago

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

ahmedGaber93 commented 2 days ago

I don't think we need to BE changes as we already have paymentType in FE, and we can use it.

ahmedGaber93 commented 2 days ago

@ahmedGaber93 , the reportAction does not have any information about how payment is done (Via Expensify or via Elsewhere). Do we first need the BE to send this info in the parentReportActions ?

@jainilparikh we already have it in another place, so no need to BE changes.

ahmedGaber93 commented 2 days ago

@trjExpensify can you please confirm is this the expected behavior?

Screenshot 2024-05-17 at 1 29 15 AM

or this https://github.com/Expensify/App/issues/41645#issuecomment-2102612537?

trjExpensify commented 1 day ago

What you're showing in that screenshot is what's expected. The report is missing the payment reportAction.

melvin-bot[bot] commented 6 hours ago

@johncschuster @ahmedGaber93 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

ahmedGaber93 commented 4 hours ago

I can't reproduce in latest main. Are I missed something? @trjExpensify

https://github.com/Expensify/App/assets/41129870/34036123-024d-44f4-91a8-1fe55500ddfd