Closed Krishna2323 closed 1 week ago
@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
š Deployed to production by https://github.com/marcaaron in version: 1.4.71-6 š
platform | result |
---|---|
š¤ android š¤ | success ā |
š„ desktop š„ | success ā |
š iOS š | success ā |
šø web šø | success ā |
Details
Fixed Issues
$ https://github.com/Expensify/App/issues/41359 PROPOSAL: https://github.com/Expensify/App/issues/41359#issuecomment-2087324383
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
https://github.com/Expensify/App/assets/85894871/14bf904c-45bd-434d-b90c-626093d1ce26Android: mWeb Chrome
https://github.com/Expensify/App/assets/85894871/354edf0b-8bca-4f1f-a5ed-20da5f629adciOS: Native
https://github.com/Expensify/App/assets/85894871/014bbe2f-8f4e-4caa-9f58-ec92ea94dcc0iOS: mWeb Safari
https://github.com/Expensify/App/assets/85894871/4752e4f1-295f-4aa2-baa9-a70245cd2a00MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/85894871/dbb090fb-6fd0-4a0b-b10e-4b9d3e125724MacOS: Desktop
https://github.com/Expensify/App/assets/85894871/ad8860b6-e1e0-4598-87ae-b45222e702f0