Open Krishna2323 opened 2 weeks ago
@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
@JmillsExpensify @sobitneupane, I found one more issue in this PR. We only show the Receipt Verified
audit, but when we have violation notices, we don't show the 'Issue/Issues found' text. The reason for that is I misunderstood this comment and hid the 'Issue/Issues found' message along with Receipt Verified
message until the receipt status is SCANCOMPLETE
but in case of issue while scanning, the receipt status is to OPEN
.
I have fixed the above issue, now it will show Issue/Issues found
if we have receipt violations and receipt is present.
Yes we shouldn't show the taxRateChanged note on NewDot, as it is being deprecated given that we have implemented that feature differently vs OldDot.
One more question on the above comment: do we also need to remove the taxAmountChanged
notice, along with taxRateChanged
, from NewDot?
https://github.com/Expensify/App/blob/550e83b2f55f0998feece27b1768ad7148d03398/src/CONST.ts#L3622
https://github.com/Expensify/App/blob/550e83b2f55f0998feece27b1768ad7148d03398/src/CONST.ts#L3624
@Krishna2323 Have we considered different types as mentioned here? Can you please complete the PR Author checklist. Please include the test cases for different types.
One more question on the above comment: do we also need to remove the taxAmountChanged notice, along with taxRateChanged, from NewDot?
@JmillsExpensify bump on the question.
Have we considered different types as mentioned https://github.com/Expensify/App/issues/41401#issuecomment-2091898713?
Code has been updated according to this, will update test cases and recordings after getting clarification on the question above.
Whoops, sorry missed this.
One more question on the above comment: do we also need to remove the taxAmountChanged notice, along with taxRateChanged, from NewDot?
Yes, that's correct. We aren't going to show these on NewDot, as both will generate system messages when changed. We also show what tax rate is "default" in a parallel initiative that's currently in implementation for track tracking in New Expensify.
Just confirming that the above response makes sense?
@JmillsExpensify, yup thats clear to me, updating the PR in few moments.
@sobitneupane, you can review the code changes now. However, I'm not sure what to add in the test cases. Could you provide some guidance? Several types of amount notices are there.
Details
Fixed Issues
$ https://github.com/Expensify/App/issues/41401 PROPOSAL: https://github.com/Expensify/App/issues/41401#issuecomment-2091932028
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop