Closed GandalfGwaihir closed 5 days ago
@ahmedGaber93 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
friendly bump @ahmedGaber93 for review
@GandalfGwaihir Reviewing today
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and not onIconClick
).myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components using Avatar
have been tested & I retested again)/** comment above it */
this
properly so there are no scoping issues (i.e. for onClick={this.submit}
the method this.submit
should be bound to this
in the constructor)this
are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this);
if this.submit
is never passed to a component event handler like onClick
)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG
)Avatar
is modified, I verified that Avatar
is working as expected in all cases)Design
label and/or tagged @Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test
steps.@GandalfGwaihir please update tests step with the following
Also use at latest on video has all steps above, you can use my video in web https://github.com/Expensify/App/assets/41129870/e017256e-d135-40bb-b006-263c52c4cd3f
Have updated the QA steps, please have a look again @ahmedGaber93
Also use at latest on video has all steps above, you can use my video in web https://github.com/Expensify/App/assets/41129870/e017256e-d135-40bb-b006-263c52c4cd3f
@GandalfGwaihir just update web video
with the link above or record your own. That can help QA to understand the steps well!
Yeah did that, thanks :)
🚀 Deployed to staging by https://github.com/cristipaval in version: 1.4.74-0 🚀
platform | result |
---|---|
🤖 android 🤖 | success ✅ |
🖥 desktop 🖥 | success ✅ |
🍎 iOS 🍎 | success ✅ |
🕸 web 🕸 | success ✅ |
Details
Tags and Categories weren't auto selected when requesting money if only 1 item from each were present, this PR fixed that issue and auto selects tag and category if only one of them is present.
Fixed Issues
$ https://github.com/Expensify/App/issues/40591 PROPOSAL: https://github.com/Expensify/App/issues/40591#issuecomment-2067416986
Tests
Same as QA
Offline tests
Same as QA
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
https://github.com/Expensify/App/assets/110545952/3993be25-1c3f-4478-98b9-8365b7c00044Android: mWeb Chrome
https://github.com/Expensify/App/assets/110545952/0fe74efe-676e-45e9-882a-04489e99f98ciOS: Native
https://github.com/Expensify/App/assets/110545952/f70c864c-c12a-4aaa-a50f-5549caf3ecffiOS: mWeb Safari
https://github.com/Expensify/App/assets/110545952/2ff9c606-5a1e-4b4f-8c42-a34f26022ce6MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/41129870/e017256e-d135-40bb-b006-263c52c4cd3fMacOS: Desktop
https://github.com/Expensify/App/assets/110545952/6035fb45-77cf-470a-ad79-c46be68dc247